[Enhancement] Make default bucket num at least 16 when table is unpartitioned #47005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meegoo
force-pushed
the
optimize_unpartition_table_default_bucket
branch
from
8bfa330
to
55c369a
Compare
nshangyiming
previously approved these changes
Jun 14, 2024
wyb
reviewed
Jun 14, 2024
| @@ -383,6 +383,10 @@ public static int calAvgBucketNumOfRecentPartitions(OlapTable olapTable, int rec | |||
| int bucketNum = 0; | |||
| if (olapTable.getPartitions().size() < recentPartitionNum || !enableAutoTabletDistribution) { | |||
| bucketNum = CatalogUtils.calBucketNumAccordingToBackends(); | |||
| // If table is not partitioned, the bucketNum should be at least 16 | |||
| if (!olapTable.getPartitionInfo().isPartitioned()) { | |||
| bucketNum = bucketNum > 16 ? bucketNum : 16; | |||
There was a problem hiding this comment.
define a variable in FeConstants?
meegoo
force-pushed
the
optimize_unpartition_table_default_bucket
branch
from
55c369a
to
3d88d0c
Compare
…titioned Signed-off-by: meegoo <[email protected]>
meegoo
force-pushed
the
optimize_unpartition_table_default_bucket
branch
from
3d88d0c
to
742230d
Compare
|
[FE Incremental Coverage Report]✅ pass : 3 / 3 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
nshangyiming
approved these changes
Jun 17, 2024
wyb
approved these changes
Jun 17, 2024
|
@Mergifyio backport branch-3.3 |
|
@Mergifyio backport branch-3.2 |
|
@Mergifyio backport branch-3.1 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 17, 2024
…titioned (#47005) Signed-off-by: meegoo <[email protected]> (cherry picked from commit 2176e83) # Conflicts: # fe/fe-core/src/test/java/com/starrocks/analysis/CTASAutoTabletTest.java
mergify bot
pushed a commit
that referenced
this pull request
Jun 17, 2024
…titioned (#47005) Signed-off-by: meegoo <[email protected]> (cherry picked from commit 2176e83)
mergify bot
pushed a commit
that referenced
this pull request
Jun 17, 2024
…titioned (#47005) Signed-off-by: meegoo <[email protected]> (cherry picked from commit 2176e83) # Conflicts: # fe/fe-core/src/test/java/com/starrocks/analysis/CTASAutoTabletTest.java
42 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Jun 17, 2024
…titioned (backport #47005) (#47103) Signed-off-by: meegoo <[email protected]> Co-authored-by: meegoo <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Jun 17, 2024
…titioned (backport #47005) (#47104) Co-authored-by: meegoo <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Jun 17, 2024
…titioned (backport #47005) (#47105) Signed-off-by: meegoo <[email protected]> Co-authored-by: meegoo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: