Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Support convert escaped characters in stream load #47302

Merged
merged 1 commit into from
Jun 24, 2024
Merged

[Enhancement] Support convert escaped characters in stream load #47302

merged 1 commit into from
Jun 24, 2024

Conversation

wyb
Copy link
Contributor

@wyb wyb commented Jun 21, 2024 •
edited by jaogoy
Loading

Why I'm doing:

stream load does not support -H "column_separator:\t" -H "row_delimiter:\n".
currently, users must use column_separator:0x09 or column_separator:\\x09.

What I'm doing:

support this

Fixes #47430

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@wyb wyb requested a review from a team as a code owner June 21, 2024 01:45
@mergify mergify bot assigned wyb Jun 21, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 21, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 4 / 4 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/analysis/Delimiter.java 4 4 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@Seaven Seaven merged commit 931d7c3 into StarRocks:main Jun 24, 2024
57 checks passed
@wyb wyb changed the title [Enhancement] Support convert escaped characters in load [Enhancement] Support convert escaped characters in stream load Jun 25, 2024
@wyb
Copy link
Contributor Author

wyb commented Jun 25, 2024

@Mergifyio backport branch-3.3

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 25, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@wyb
Copy link
Contributor Author

wyb commented Jun 25, 2024

@Mergifyio backport branch-3.2

@wyb
Copy link
Contributor Author

wyb commented Jun 25, 2024

@Mergifyio backport branch-3.1

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 25, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 25, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 25, 2024
@wyb @mergify
[Enhancement] Support convert escaped characters in load (#47302)
c36d8ed 
Signed-off-by: wyb <[email protected]>
(cherry picked from commit 931d7c3)
@mergify mergify bot mentioned this pull request Jun 25, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Jun 25, 2024
@wyb @mergify
[Enhancement] Support convert escaped characters in load (#47302)
eb5d5fa 
Signed-off-by: wyb <[email protected]>
(cherry picked from commit 931d7c3)
@mergify mergify bot mentioned this pull request Jun 25, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Jun 25, 2024
@wyb @mergify
[Enhancement] Support convert escaped characters in load (#47302)
9cd9851 
Signed-off-by: wyb <[email protected]>
(cherry picked from commit 931d7c3)
@mergify mergify bot mentioned this pull request Jun 25, 2024
Merged
42 tasks
@jaogoy jaogoy mentioned this pull request Jun 25, 2024
Closed
1 task
wanpengfei-git pushed a commit that referenced this pull request Jun 25, 2024
@mergify @wyb
[Enhancement] Support convert escaped characters in stream load (back…
47d269f 
…port #47302) (#47428)

Co-authored-by: wyb <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Jun 25, 2024
@mergify @wyb
[Enhancement] Support convert escaped characters in stream load (back…
5a80b61 
…port #47302) (#47427)

Co-authored-by: wyb <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Jun 25, 2024
@mergify @wyb
[Enhancement] Support convert escaped characters in stream load (back…
5ffb719 
…port #47302) (#47429)

Co-authored-by: wyb <[email protected]>
happut pushed a commit to happut/starrocks that referenced this pull request Jun 26, 2024
@wyb @happut
[Enhancement] Support convert escaped characters in load (StarRocks#4…
1010488 
…7302)

Signed-off-by: wyb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaogoy jaogoy jaogoy approved these changes

@Seaven Seaven Seaven approved these changes

@meegoo meegoo meegoo approved these changes

Assignees

@wyb wyb

Labels
3.1-merged 3.1 3.2-merged 3.2 3.3-merged 3.3 behavior_changed
Projects
None yet
Milestone
No milestone
4 participants
@wyb @meegoo @Seaven @jaogoy