Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix push down predicate on repeat node check #47484

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

Seaven
Copy link
Contributor

@Seaven Seaven commented Jun 25, 2024

Why I'm doing:

select * from (
select v1, v2, v3
from t0 group by rollup(v1, v2, v3)
) x where coalesce(v1, v2, v3) = 1;

repeat node will take different v1/v2/v3 with null, can't push down predicate directly

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@Seaven Seaven requested a review from a team as a code owner June 25, 2024 12:14
return false;
} else if (!(nullEval instanceof ConstantOperator)) {
return false;
}
}
return true;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most risky bug in this code is:
Using Maps.of instead of Collections.singletonMap.

You can modify the code like this:

import java.util.Collections;

// Replace org.apache.groovy.util.Maps with java.util.Collections

...
+            // need check repeat column one by one
+            Map<ColumnRefOperator, ScalarOperator> m =
+                    Collections.singletonMap(repeatColumn, ConstantOperator.createNull(repeatColumn.getType()));

@mergify mergify bot assigned Seaven Jun 25, 2024
Copy link

sonarcloud bot commented Jun 25, 2024

Copy link

[FE Incremental Coverage Report]

pass : 15 / 15 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateRepeatRule.java 15 15 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@satanson satanson merged commit 7d051b8 into StarRocks:main Jun 26, 2024
56 checks passed
happut pushed a commit to happut/starrocks that referenced this pull request Jun 26, 2024
@Seaven
Copy link
Contributor Author

Seaven commented Aug 23, 2024

@mergify backport branch-3.3 branch-3.2 branch-3.1 branch-3.0 branch-2.5

Copy link
Contributor

mergify bot commented Aug 23, 2024

backport branch-3.3 branch-3.2 branch-3.1 branch-3.0 branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 23, 2024
mergify bot pushed a commit that referenced this pull request Aug 23, 2024
mergify bot pushed a commit that referenced this pull request Aug 23, 2024
mergify bot pushed a commit that referenced this pull request Aug 23, 2024
mergify bot pushed a commit that referenced this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants