-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Fix push down predicate on repeat node check #47484
Conversation
return false; | ||
} else if (!(nullEval instanceof ConstantOperator)) { | ||
return false; | ||
} | ||
} | ||
return true; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The most risky bug in this code is:
Using Maps.of
instead of Collections.singletonMap
.
You can modify the code like this:
import java.util.Collections;
// Replace org.apache.groovy.util.Maps with java.util.Collections
...
+ // need check repeat column one by one
+ Map<ColumnRefOperator, ScalarOperator> m =
+ Collections.singletonMap(repeatColumn, ConstantOperator.createNull(repeatColumn.getType()));
Signed-off-by: Seaven <[email protected]>
Quality Gate passedIssues Measures |
[FE Incremental Coverage Report]✅ pass : 15 / 15 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Signed-off-by: Seaven <[email protected]>
@mergify backport branch-3.3 branch-3.2 branch-3.1 branch-3.0 branch-2.5 |
✅ Backports have been created
|
Signed-off-by: Seaven <[email protected]> (cherry picked from commit 7d051b8)
Signed-off-by: Seaven <[email protected]> (cherry picked from commit 7d051b8)
Signed-off-by: Seaven <[email protected]> (cherry picked from commit 7d051b8)
Signed-off-by: Seaven <[email protected]> (cherry picked from commit 7d051b8)
Signed-off-by: Seaven <[email protected]> (cherry picked from commit 7d051b8)
… (#50204) Co-authored-by: Seaven <[email protected]>
… (#50202) Co-authored-by: Seaven <[email protected]>
… (#50203) Co-authored-by: Seaven <[email protected]>
… (#50200) Co-authored-by: Seaven <[email protected]>
… (#50201) Co-authored-by: Seaven <[email protected]>
Why I'm doing:
repeat node will take different v1/v2/v3 with null, can't push down predicate directly
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: