Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Improve kafka authentication error message #47649

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

wyb
Copy link
Contributor

@wyb wyb commented Jun 28, 2024

Why I'm doing:

kafka server uses sasl_ssl but create routine load job with security.protocol = sasl_plaintext

ErrorReason{errCode = 4, msg='Job failed to fetch all current partition with error [failed to get kafka topic: test meta, err: Local: Broker transport failure, , BE: TNetworkAddress(hostname:127.0.0.1, port:8060)]'}

What I'm doing:

the authentication errors event only be triggered when the consumer is closed.
close consumer and wait the errors event when message is empty.

ErrorReason{errCode = 4, msg='Job failed to fetch all current partition with error [failed to get kafka topic: test meta, err: Local: Broker transport failure, event: 127.0.0.1:9092/bootstrap: Disconnected while requesting ApiVersion: might be caused by incorrect security.protocol configuration (connecting to a SSL listener?) or broker version is < 0.10 (see api.version.request) (after 5003ms in state APIVERSION_QUERY), BE: TNetworkAddress(hostname:127.0.0.1, port:8060)]'}

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 9 / 10 (90.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/runtime/routine_load/data_consumer.cpp 7 8 87.50% [352]
🔵 be/src/runtime/routine_load/data_consumer.h 2 2 100.00% []

@luohaha luohaha enabled auto-merge (squash) July 16, 2024 03:44
@wanpengfei-git wanpengfei-git merged commit f17f645 into StarRocks:main Jul 17, 2024
50 checks passed
Copy link

@Mergifyio backport branch-3.3

Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.3 label Jul 17, 2024
Copy link

@Mergifyio backport branch-3.1

Copy link
Contributor

mergify bot commented Jul 17, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Jul 17, 2024

backport branch-3.2

✅ Backports have been created

Copy link
Contributor

mergify bot commented Jul 17, 2024

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 17, 2024
mergify bot pushed a commit that referenced this pull request Jul 17, 2024
mergify bot pushed a commit that referenced this pull request Jul 17, 2024
Signed-off-by: wyb <[email protected]>
(cherry picked from commit f17f645)

# Conflicts:
#	be/src/runtime/routine_load/data_consumer.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants