Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix parse Mysql Client Protocol COM_CHANGE_USER with conn_attr error bug #47796

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

HangyuanLiu
Copy link
Contributor

@HangyuanLiu HangyuanLiu commented Jul 3, 2024

Why I'm doing:

refer : https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_com_change_user.html

What I'm doing:

There is an error when parsing the conn_attr field of COM_CHANGE_USER, because that field is the length of the following attr, not the number of attrs.
Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Copy link

sonarcloud bot commented Jul 3, 2024

Copy link

github-actions bot commented Jul 3, 2024

[FE Incremental Coverage Report]

pass : 4 / 4 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/mysql/MysqlChangeUserPacket.java 4 4 100.00% []

Copy link

github-actions bot commented Jul 3, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@trueeyu trueeyu merged commit 66388e7 into StarRocks:main Jul 3, 2024
61 of 63 checks passed
Copy link

github-actions bot commented Jul 3, 2024

@Mergifyio backport branch-3.3

Copy link

github-actions bot commented Jul 3, 2024

@Mergifyio backport branch-3.2

Copy link

github-actions bot commented Jul 3, 2024

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Jul 3, 2024
Copy link

github-actions bot commented Jul 3, 2024

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Jul 3, 2024
Copy link
Contributor

mergify bot commented Jul 3, 2024

backport branch-3.3

✅ Backports have been created

Copy link

github-actions bot commented Jul 3, 2024

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label Jul 3, 2024
Copy link
Contributor

mergify bot commented Jul 3, 2024

backport branch-3.2

✅ Backports have been created

Copy link
Contributor

mergify bot commented Jul 3, 2024

backport branch-3.1

✅ Backports have been created

Copy link
Contributor

mergify bot commented Jul 3, 2024

backport branch-3.0

✅ Backports have been created

Copy link
Contributor

mergify bot commented Jul 3, 2024

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 3, 2024
…tr error bug (#47796)

Signed-off-by: HangyuanLiu <[email protected]>
(cherry picked from commit 66388e7)
mergify bot pushed a commit that referenced this pull request Jul 3, 2024
…tr error bug (#47796)

Signed-off-by: HangyuanLiu <[email protected]>
(cherry picked from commit 66388e7)
mergify bot pushed a commit that referenced this pull request Jul 3, 2024
…tr error bug (#47796)

Signed-off-by: HangyuanLiu <[email protected]>
(cherry picked from commit 66388e7)
mergify bot pushed a commit that referenced this pull request Jul 3, 2024
…tr error bug (#47796)

Signed-off-by: HangyuanLiu <[email protected]>
(cherry picked from commit 66388e7)
mergify bot pushed a commit that referenced this pull request Jul 3, 2024
…tr error bug (#47796)

Signed-off-by: HangyuanLiu <[email protected]>
(cherry picked from commit 66388e7)
wanpengfei-git pushed a commit that referenced this pull request Jul 3, 2024
wanpengfei-git pushed a commit that referenced this pull request Jul 3, 2024
wanpengfei-git pushed a commit that referenced this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants