[BugFix] follower sync dictionary refresh state

[srlch]

Why I'm doing:

In the current implementations, follower will not be synced any information about the dictionary refreshing which is a problem.

What I'm doing:

Reuse dictionaryMgrInfo and DICTIONARY_MODIFY log to save the dictionary state information.

Fixes #issue
https://github.com/StarRocks/StarRocksTest/issues/7961

What type of PR is this:

• BugFix
• Feature
• Enhancement
• Refactor
• UT
• Doc
• Tool

Does this PR entail a change in behavior?

• Yes, this PR will result in a change in behavior.
• No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

• Interface/UI changes: syntax, type conversion, expression evaluation, display information
• Parameter changes: default values, similar parameters but with different default values
• Policy changes: use new policy to replace old one, functionality automatically enabled
• Feature removed
• Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

• I have added test cases for my bug fix or my new feature
• This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function
• This is a backport pr

Bugfix cherry-pick branch check:

• I have checked the version labels which the pr will be auto-backported to the target branch
  • 3.3
  • 3.2
  • 3.1
  • 3.0
  • 2.5

[starrocks-cr]

The most risky bug in this code is:
Missing semicolon after last_success_finished_time.

You can modify the code like this:

struct TUpdateFollowerDictionaryStateParams {
    1: optional i64 dictionary_id;
    2: optional i64 success_txn_id;
    3: optional bool error;
    4: optional string error_msg;
    5: optional i64 last_success_finished_time;
}

[starrocks-cr]

The most risky bug in this code is:
Failure to synchronize dictionary states can lead to inconsistencies among followers.

You can modify the code like this:

public TUpdateFollowerDictionaryStateResult updateFollowerDictionaryState(TUpdateFollowerDictionaryStateParams request) {
    TUpdateFollowerDictionaryStateResult result = new TUpdateFollowerDictionaryStateResult();
    long leaderDictionaryId = request.getDictionary_id();  // Use getter methods for encapsulation
    long leaderSuccessTxnId = request.getSuccess_txn_id(); // Same here
    boolean error = request.isError(); // get request parameters properly
    String errMsg = request.getError_msg(); // get request parameters properly
    long lastSuccessFinishedTime = request.getLast_success_finished_time(); // use getter method

    Dictionary dictionary = dictionariesMapById.get(leaderDictionaryId);
    if (dictionary == null) {
        LOG.warn("Dictionary does not exist when sync the refresh state to follower, dictionary id: {}", leaderDictionaryId);
        return result;
    }
    if (!error) {
        GlobalStateMgr.getCurrentState().getDictionaryMgr().updateLastSuccessTxnId(leaderDictionaryId, leaderSuccessTxnId);
        dictionary.setFinished(lastSuccessFinishedTime); // update with correct finished time
        dictionary.setErrorMsg(""); // reset error msg
    } else if (dictionary.getIgnoreFailedRefresh()) {
        dictionary.resetStateBeforeRefresh();
        dictionary.setErrorMsg("Cancelled and rollback to previous state, errMsg: " + errMsg);
    } else {
        dictionary.setCancelled();
        dictionary.setErrorMsg(errMsg);
    }

    return result;
}

Additional explanation:

1. Getter Methods: Ensure you're using getter methods (request.getDictionary_id(), etc.) instead of accessing fields directly. This follows Java best practices for encapsulation.
2. Proper Error Handling: Consistently handle any potential errors by accurately updating the Dictionary object.
3. Consistency Check: Ensure consistency checks between leader and followers are adequately addressed, which includes proper synchronization mechanisms if needed.

[sonarcloud]

Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

[FE Incremental Coverage Report]

✅ pass : 64 / 74 (86.49%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/catalog/DictionaryMgr.java	40	50	80.00%	[124, 494, 495, 496, 497, 499, 501, 502, 504, 536]
🔵	com/starrocks/persist/DictionaryMgrInfo.java	9	9	100.00%	[]
🔵	com/starrocks/catalog/Dictionary.java	15	15	100.00%	[]

[github-actions]

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

[github-actions]

@Mergifyio backport branch-3.3

[mergify]

backport branch-3.3

✅ Backports have been created

• #48252 [BugFix] follower sync dictionary refresh state (backport #47802) has been created for branch branch-3.3