[Enhancement] Limit the number of partitions initially opened by expression partition ingestion #47976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
meegoo
force-pushed
the
optimize_open_tablet
branch
from
825afcb
to
5e4d5d3
Compare
jaogoy
reviewed
Jul 18, 2024
meegoo
force-pushed
the
optimize_open_tablet
branch
2 times, most recently
from
1d0f825
to
a50d1c7
Compare
…ession partition ingestion Signed-off-by: meegoo <[email protected]>
meegoo
force-pushed
the
optimize_open_tablet
branch
from
a50d1c7
to
eccc6d7
Compare
|
[FE Incremental Coverage Report]✅ pass : 10 / 11 (90.91%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
|
need backport to 3.3 & 3.2 & 3.1 |
jaogoy
reviewed
Jul 25, 2024
| * Used to limit num of partition for load open partition number | ||
| */ | ||
| @ConfField(mutable = true) | ||
| public static long max_load_initial_open_partition_number = 32; |
There was a problem hiding this comment.
Why should some partitions initially opened for data loading in an expression partitioned table.
There was a problem hiding this comment.
For most scenarios, data is often only loaded into the nearest partition. Opening it in advance can avoid additional RPC requests at runtime.
wyb
approved these changes
Jul 31, 2024
jaogoy
approved these changes
Jul 31, 2024
|
@mergify backport branch-3.3 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
…ession partition ingestion (#47976) Signed-off-by: meegoo <[email protected]> (cherry picked from commit 92e29e1)
42 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Nov 5, 2024
…ession partition ingestion (backport #47976) (#52619) Co-authored-by: meegoo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Currently, when we ingest data, unless a partition is specified, information for all partitions is sent, causing the storage side to open delta writers for all partitions. When there are many partitions, this can consume a large amount of unnecessary memory, even though only a few partitions typically have data written to them.
What I'm doing:
This optimization controls the number of partitions sent, allowing the storage side to initially open fewer delta writers. Subsequently, using a mechanism similar to expression partitioning, it dynamically opens the required partitions based on the data during runtime. This approach can significantly reduce memory consumption.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: