Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] check if BinaryOutputArchive write success #48045

Merged
merged 1 commit into from
Jul 9, 2024
Merged

[BugFix] check if BinaryOutputArchive write success #48045

merged 1 commit into from
Jul 9, 2024

Conversation

luohaha
Copy link
Contributor

@luohaha luohaha commented Jul 9, 2024 •
edited
Loading

Why I'm doing:

What I'm doing:

Persistent Index use BinaryOutputArchive to generate l0 snapshot, and if BinaryOutputArchive write fail and return true, it will lead to l0 lost data and cause PK table issue like:

load primary index failed: Already exist: FixedMutableIndex<16> insert found duplicate key 800000003B9ACF8D80000000411AB34E, new(rssid=11649 rowid=0), old(rssid=11645 rowid=0)

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@luohaha luohaha requested a review from a team as a code owner July 9, 2024 10:32
@mergify mergify bot assigned luohaha Jul 9, 2024
@alvin-celerdata
Copy link
Contributor

@mergify rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 9, 2024

rebase

✅ Branch has been successfully rebased

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

[BE Incremental Coverage Report]

✅ pass : 2 / 2 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/util/phmap/phmap_dump.h 2 2 100.00% []

@alvin-celerdata alvin-celerdata merged commit 0726e39 into StarRocks:main Jul 9, 2024
45 of 46 checks passed
@luohaha luohaha mentioned this pull request Jul 10, 2024
Merged
24 tasks
@luohaha
Copy link
Contributor Author

luohaha commented Jul 10, 2024

https://github.com/Mergifyio backport branch-3.3

@luohaha
Copy link
Contributor Author

luohaha commented Jul 10, 2024

https://github.com/Mergifyio backport branch-3.2

@luohaha
Copy link
Contributor Author

luohaha commented Jul 10, 2024

https://github.com/Mergifyio backport branch-3.1

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 10, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 10, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@luohaha
Copy link
Contributor Author

luohaha commented Jul 10, 2024

https://github.com/Mergifyio backport branch-3.0

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 10, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@luohaha
Copy link
Contributor Author

luohaha commented Jul 10, 2024

https://github.com/Mergifyio backport branch-2.5

mergify bot pushed a commit that referenced this pull request Jul 10, 2024
@luohaha @mergify
[BugFix] check if BinaryOutputArchive write success (#48045)
81f3b79 
Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 0726e39)
@mergify mergify bot mentioned this pull request Jul 10, 2024
Merged
42 tasks
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 10, 2024 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 10, 2024 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 10, 2024
@luohaha @mergify
[BugFix] check if BinaryOutputArchive write success (#48045)
13e0fd7 
Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 0726e39)
mergify bot pushed a commit that referenced this pull request Jul 10, 2024
@luohaha @mergify
[BugFix] check if BinaryOutputArchive write success (#48045)
46c1a0b 
Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 0726e39)
This was referenced Jul 10, 2024
Merged
Merged
mergify bot pushed a commit that referenced this pull request Jul 10, 2024
@luohaha @mergify
[BugFix] check if BinaryOutputArchive write success (#48045)
6450a33 
Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 0726e39)
@mergify mergify bot mentioned this pull request Jul 10, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Jul 10, 2024
@luohaha @mergify
[BugFix] check if BinaryOutputArchive write success (#48045)
3baa595 
Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 0726e39)
@mergify mergify bot mentioned this pull request Jul 10, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Jul 10, 2024
@mergify @luohaha
[BugFix] check if BinaryOutputArchive write success (backport #48045) (…
55e5efb 
…#48077)

Co-authored-by: Yixin Luo <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Jul 10, 2024
@mergify @luohaha
[BugFix] check if BinaryOutputArchive write success (backport #48045) (…
02c6aed 
…#48078)

Co-authored-by: Yixin Luo <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Jul 10, 2024
@mergify @luohaha
[BugFix] check if BinaryOutputArchive write success (backport #48045) (…
88498a5 
…#48076)

Co-authored-by: Yixin Luo <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Jul 10, 2024
@mergify @luohaha
[BugFix] check if BinaryOutputArchive write success (backport #48045) (…
5675f82 
…#48079)

Co-authored-by: Yixin Luo <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Jul 10, 2024
@mergify @luohaha
[BugFix] check if BinaryOutputArchive write success (backport #48045) (…
3664fa0 
…#48075)

Co-authored-by: Yixin Luo <[email protected]>
This was referenced Jul 10, 2024
Merged
Merged
Merged
Merged
Merged
smartlxh pushed a commit to smartlxh/starrocks that referenced this pull request Oct 16, 2024
@wxl24life @luohaha @smartlxh
[Backport][BugFix] check if BinaryOutputArchive write success (backport
6bc4caf 
StarRocks#48045) (StarRocks#48076)

Co-authored-by: Yixin Luo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvin-celerdata alvin-celerdata alvin-celerdata approved these changes

Assignees

@luohaha luohaha

Labels
2.5-merged 2.5 3.0-merged 3.0 3.1-merged 3.1 3.2-merged 3.2 3.3-merged 3.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luohaha @alvin-celerdata