Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix csv converter and chunk column inconsistent in select into outfile #48052

Merged

Conversation

wyb
Copy link
Contributor

@wyb wyb commented Jul 9, 2024

Why I'm doing:

in some cases, the nullable property between the column in the chunk and _output_expr_ctxs may not be consistent.
for example: order by limit + left outer join

select t1.k1, t1.k2, count(distinct t1.k3) as k33
from t1 left join t2 on t1.k1 = t2.k1
group by t1.k1,t1.k2 
order by k33

the result will be wrong if inconsistent.

What I'm doing:

use nullable converter, and process whether the column is nullable in the nullable converter.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@wyb wyb force-pushed the converter_column_not_inconsistent branch 2 times, most recently from 23ca8b9 to dc1cfb0 Compare July 9, 2024 14:10
@wyb wyb force-pushed the converter_column_not_inconsistent branch from dc1cfb0 to 6190ddd Compare July 9, 2024 14:11
Copy link

github-actions bot commented Jul 9, 2024

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Jul 9, 2024

[BE Incremental Coverage Report]

pass : 24 / 25 (96.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exec/plain_text_builder.cpp 8 9 88.89% [70]
🔵 be/src/formats/csv/nullable_converter.cpp 16 16 100.00% []

@wyb wyb requested review from meegoo and satanson July 10, 2024 01:06
@wanpengfei-git wanpengfei-git merged commit 498c39a into StarRocks:main Jul 16, 2024
53 checks passed
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Jul 16, 2024
Copy link

@Mergifyio backport branch-3.2

Copy link

@Mergifyio backport branch-3.1

Copy link

@Mergifyio backport branch-3.0

Copy link
Contributor

mergify bot commented Jul 16, 2024

backport branch-3.1

✅ Backports have been created

Copy link
Contributor

mergify bot commented Jul 16, 2024

backport branch-3.0

✅ Backports have been created

Copy link
Contributor

mergify bot commented Jul 16, 2024

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 16, 2024
mergify bot pushed a commit that referenced this pull request Jul 16, 2024
mergify bot pushed a commit that referenced this pull request Jul 16, 2024
mergify bot pushed a commit that referenced this pull request Jul 16, 2024
mergify bot pushed a commit that referenced this pull request Jul 16, 2024
…to outfile (#48052)

Signed-off-by: wyb <[email protected]>
(cherry picked from commit 498c39a)

# Conflicts:
#	be/src/exec/plain_text_builder.cpp
#	be/test/formats/csv/nullable_converter_test.cpp
wanpengfei-git pushed a commit that referenced this pull request Jul 16, 2024
wanpengfei-git pushed a commit that referenced this pull request Jul 16, 2024
wanpengfei-git pushed a commit that referenced this pull request Jul 16, 2024
wanpengfei-git pushed a commit that referenced this pull request Jul 16, 2024
zhangheihei pushed a commit to zhangheihei/starrocks that referenced this pull request Jul 18, 2024
wyb added a commit that referenced this pull request Jul 19, 2024
dujijun007 pushed a commit to dujijun007/starrocks that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants