-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Fix csv converter and chunk column inconsistent in select into outfile #48052
Merged
wanpengfei-git
merged 1 commit into
StarRocks:main
from
wyb:converter_column_not_inconsistent
Jul 16, 2024
Merged
[BugFix] Fix csv converter and chunk column inconsistent in select into outfile #48052
wanpengfei-git
merged 1 commit into
StarRocks:main
from
wyb:converter_column_not_inconsistent
Jul 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyb
force-pushed
the
converter_column_not_inconsistent
branch
2 times, most recently
from
July 9, 2024 14:10
23ca8b9
to
dc1cfb0
Compare
…to outfile Signed-off-by: wyb <[email protected]>
wyb
force-pushed
the
converter_column_not_inconsistent
branch
from
July 9, 2024 14:11
dc1cfb0
to
6190ddd
Compare
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 24 / 25 (96.00%) file detail
|
tracymacding
approved these changes
Jul 12, 2024
satanson
approved these changes
Jul 12, 2024
luohaha
approved these changes
Jul 16, 2024
sevev
approved these changes
Jul 16, 2024
@Mergifyio backport branch-3.3 |
@Mergifyio backport branch-3.2 |
@Mergifyio backport branch-3.1 |
@Mergifyio backport branch-3.0 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
…to outfile (#48052) Signed-off-by: wyb <[email protected]> (cherry picked from commit 498c39a)
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
…to outfile (#48052) Signed-off-by: wyb <[email protected]> (cherry picked from commit 498c39a)
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
…to outfile (#48052) Signed-off-by: wyb <[email protected]> (cherry picked from commit 498c39a)
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
…to outfile (#48052) Signed-off-by: wyb <[email protected]> (cherry picked from commit 498c39a)
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
…to outfile (#48052) Signed-off-by: wyb <[email protected]> (cherry picked from commit 498c39a) # Conflicts: # be/src/exec/plain_text_builder.cpp # be/test/formats/csv/nullable_converter_test.cpp
42 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Jul 16, 2024
…to outfile (backport #48052) (#48438) Co-authored-by: wyb <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Jul 16, 2024
…to outfile (backport #48052) (#48439) Co-authored-by: wyb <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Jul 16, 2024
…to outfile (backport #48052) (#48440) Co-authored-by: wyb <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Jul 16, 2024
…to outfile (backport #48052) (#48441) Co-authored-by: wyb <[email protected]>
zhangheihei
pushed a commit
to zhangheihei/starrocks
that referenced
this pull request
Jul 18, 2024
…to outfile (StarRocks#48052) Signed-off-by: wyb <[email protected]>
wyb
added a commit
that referenced
this pull request
Jul 19, 2024
…to outfile (backport #48052) (#48437) Co-authored-by: wyb <[email protected]>
dujijun007
pushed a commit
to dujijun007/starrocks
that referenced
this pull request
Jul 29, 2024
…to outfile (StarRocks#48052) Signed-off-by: wyb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
in some cases, the nullable property between
the column in the chunk
and_output_expr_ctxs
may not be consistent.for example: order by limit + left outer join
the result will be wrong if inconsistent.
What I'm doing:
use nullable converter, and process whether the column is nullable in the nullable converter.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: