[Enhancement] make report audit statistics in sink operator asynchronous #48162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: luohaha <[email protected]>
tracymacding
approved these changes
Jul 11, 2024
|
it seems _is_audit_report_done in OlapTableSink is unnecessary? |
Yes, I think so, because we didn't handle report failure now, so there is no guarantee that the report will be successful |
Signed-off-by: luohaha <[email protected]>
stdpain
approved these changes
Jul 18, 2024
wyb
approved these changes
Jul 18, 2024
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]❌ fail : 4 / 7 (57.14%) file detail
|
|
@Mergifyio backport branch-3.3 |
|
@Mergifyio backport branch-3.2 |
|
@Mergifyio backport branch-3.1 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
…ous (#48162) Signed-off-by: luohaha <[email protected]> (cherry picked from commit ca5a6db)
Merged
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
…ous (#48162) Signed-off-by: luohaha <[email protected]> (cherry picked from commit ca5a6db)
Merged
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
…ous (#48162) Signed-off-by: luohaha <[email protected]> (cherry picked from commit ca5a6db)
Merged
42 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Jul 18, 2024
…ous (backport #48162) (#48584) Co-authored-by: Yixin Luo <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Jul 18, 2024
…ous (backport #48162) (#48583) Co-authored-by: Yixin Luo <[email protected]>
luohaha
added a commit
that referenced
this pull request
Jul 19, 2024
…ous (backport #48162) (#48582) Co-authored-by: Yixin Luo <[email protected]>
dujijun007
pushed a commit
to dujijun007/starrocks
that referenced
this pull request
Jul 29, 2024
…ous (StarRocks#48162) Signed-off-by: luohaha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
In this PR #38032, we already introduce a asynchronous audit statistics reporter, but it doesn't work because we set
doneflag when this job begin to be execute and if too many jobs waiting to be executed, it will still make sink operator hang waiting report statistics finish.What I'm doing:
Sink operator won't wait for audit statistics report.
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: