Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix concurrent execute let rewrite failed #48180

Merged
merged 1 commit into from
Jul 11, 2024
Merged

[BugFix] Fix concurrent execute let rewrite failed #48180

merged 1 commit into from
Jul 11, 2024

Conversation

Seaven
Copy link
Contributor

@Seaven Seaven commented Jul 11, 2024 •
edited
Loading

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@Seaven Seaven requested a review from a team as a code owner July 11, 2024 03:31
@mergify mergify bot assigned Seaven Jul 11, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 3 / 3 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateProjectRule.java 3 3 100.00% []

@kangkaisen kangkaisen merged commit 0dbfb59 into StarRocks:main Jul 11, 2024
93 of 96 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Jul 11, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.2 label Jul 11, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label Jul 11, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 11, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 11, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 11, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 11, 2024 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 11, 2024 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 11, 2024
@Seaven @mergify
[BugFix] Fix concurrent execute let rewrite failed (#48180)
c835b1c 
Signed-off-by: Seaven <[email protected]>
(cherry picked from commit 0dbfb59)
mergify bot pushed a commit that referenced this pull request Jul 11, 2024
@Seaven @mergify
[BugFix] Fix concurrent execute let rewrite failed (#48180)
04ed033 
Signed-off-by: Seaven <[email protected]>
(cherry picked from commit 0dbfb59)
This was referenced Jul 11, 2024
Merged
Merged
mergify bot pushed a commit that referenced this pull request Jul 11, 2024
@Seaven @mergify
[BugFix] Fix concurrent execute let rewrite failed (#48180)
e949ac2 
Signed-off-by: Seaven <[email protected]>
(cherry picked from commit 0dbfb59)
@mergify mergify bot mentioned this pull request Jul 11, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Jul 11, 2024
@Seaven @mergify
[BugFix] Fix concurrent execute let rewrite failed (#48180)
7778d2e 
Signed-off-by: Seaven <[email protected]>
(cherry picked from commit 0dbfb59)
mergify bot pushed a commit that referenced this pull request Jul 11, 2024
@Seaven @mergify
[BugFix] Fix concurrent execute let rewrite failed (#48180)
bb5c5c8 
Signed-off-by: Seaven <[email protected]>
(cherry picked from commit 0dbfb59)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateProjectRule.java
This was referenced Jul 11, 2024
Merged
Merged
Seaven added a commit that referenced this pull request Jul 11, 2024
@Seaven
[BugFix] Fix concurrent execute let rewrite failed (#48180)
66de81c 
Signed-off-by: Seaven <[email protected]>
(cherry picked from commit 0dbfb59)
wanpengfei-git pushed a commit that referenced this pull request Jul 11, 2024
@mergify @Seaven
[BugFix] Fix concurrent execute let rewrite failed (backport #48180) (#…
db50e29 
…48206)

Co-authored-by: Seaven <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Jul 11, 2024
@mergify @Seaven
[BugFix] Fix concurrent execute let rewrite failed (backport #48180) (#…
eec133b 
…48204)

Co-authored-by: Seaven <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Jul 11, 2024
@mergify @Seaven
[BugFix] Fix concurrent execute let rewrite failed (backport #48180) (#…
f89bab9 
…48205)

Co-authored-by: Seaven <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Jul 11, 2024
@mergify @Seaven
[BugFix] Fix concurrent execute let rewrite failed (backport #48180) (#…
907b084 
…48203)

Co-authored-by: Seaven <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Jul 11, 2024
@mergify @Seaven
[BugFix] Fix concurrent execute let rewrite failed (backport #48180) (#…
bb8ec72 
…48202)

Co-authored-by: Seaven <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@packy92 packy92 packy92 approved these changes

@kangkaisen kangkaisen kangkaisen approved these changes

Assignees

@Seaven Seaven

Labels
2.5-merged 3.0-merged 3.1-merged 3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Seaven @kangkaisen @packy92