-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Fix the bug of array out-of-bounds access #48230
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sevev <[email protected]>
Signed-off-by: sevev <[email protected]>
Signed-off-by: sevev <[email protected]>
Signed-off-by: sevev <[email protected]>
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 5 / 5 (100.00%) file detail
|
luohaha
approved these changes
Jul 12, 2024
wyb
approved these changes
Jul 12, 2024
@Mergifyio backport branch-3.3 |
@Mergifyio backport branch-3.2 |
@Mergifyio backport branch-3.1 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 12, 2024
Signed-off-by: sevev <[email protected]> (cherry picked from commit 5725f4c)
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jul 12, 2024
Signed-off-by: sevev <[email protected]> (cherry picked from commit 5725f4c)
mergify bot
pushed a commit
that referenced
this pull request
Jul 12, 2024
Signed-off-by: sevev <[email protected]> (cherry picked from commit 5725f4c) # Conflicts: # be/test/storage/persistent_index_test.cpp
This was referenced Jul 12, 2024
wanpengfei-git
pushed a commit
that referenced
this pull request
Jul 12, 2024
…48245) Co-authored-by: zhangqiang <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Jul 12, 2024
…48246) Co-authored-by: zhangqiang <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Jul 12, 2024
…48247) Signed-off-by: sevev <[email protected]> Co-authored-by: zhangqiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing
Pindex support page compression after version 3.1.13/3.2.9, and we will record each page compressed size into
page_off
which is a vector. However, if you upgrade from old version and disable pindex shard compression in pre-version, thepage_off
only keep one element and you may meet out-of-bounds access.The stack is following:
What I'm doing:
Initial
page_off
if BE is upgrade from old version.Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: