[Feature] adapt limit for sqlserver (#48214) #48248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: XinzhuangL <[email protected]>
zombee0
reviewed
Jul 12, 2024
| @@ -51,6 +51,10 @@ static std::string get_jdbc_sql(const Slice jdbc_url, const std::string& table, | |||
| const std::vector<std::string>& filters, int64_t limit) { | |||
| std::ostringstream oss; | |||
| oss << "SELECT"; | |||
| if (limit != -1 && jdbc_url.starts_with("jdbc:sqlserver")) { | |||
There was a problem hiding this comment.
i think for sqlserver the sql will be select top(xx) xxx from xxx limit xxx;
There was a problem hiding this comment.
i set the limit=-1, this code "if (limit != -1) {
if (jdbc_url.starts_with("jdbc:oracle")) {
// oracle doesn't support limit clause, we should generate a subquery to do this
// ref: https://stackoverflow.com/questions/470542/how-do-i-limit-the-number-of-rows-returned-by-an-oracle-query-after-ordering
return fmt::format("SELECT * FROM ({}) WHERE ROWNUM <= {}", oss.str(), limit);
} else {
oss << " LIMIT " << limit;
}
}" is no longer valid ?
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]❌ fail : 1 / 3 (33.33%) file detail
|
zombee0
approved these changes
Jul 15, 2024
2 tasks
|
https://github.com/Mergifyio backport branch-3.3 |
✅ Backports have been created
|
42 tasks
LiShuMing
pushed a commit
that referenced
this pull request
Aug 13, 2024
wanpengfei-git
pushed a commit
that referenced
this pull request
Aug 13, 2024
Co-authored-by: fl4me <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
Fixes #48214
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: