Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix load boolean from json #48387

Merged
merged 2 commits into from
Jul 25, 2024
Merged

[BugFix] Fix load boolean from json #48387

merged 2 commits into from
Jul 25, 2024

Conversation

wyb
Copy link
Contributor

@wyb wyb commented Jul 15, 2024 •
edited
Loading

Why I'm doing:

What I'm doing:

according to json type

  1. boolean: true or false
  2. number: !=0 is true else false
  3. string: int32_t string, "true"(case insensitive) is true; "0", "false" is false, others is invalid
  4. other type: invalid

Fixes https://github.com/StarRocks/StarRocksTest/issues/8095

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@wyb wyb requested a review from a team as a code owner July 15, 2024 14:31
@mergify mergify bot assigned wyb Jul 15, 2024
@wyb wyb force-pushed the json_boolean branch 4 times, most recently from 89c906c to e1e56f0 Compare July 16, 2024 02:01
@wyb wyb force-pushed the json_boolean branch 2 times, most recently from 7600a87 to 3e1ef8a Compare July 17, 2024 12:07
luohaha
luohaha previously approved these changes Jul 19, 2024
View reviewed changes
banmoy
banmoy approved these changes Jul 19, 2024
View reviewed changes
be/src/formats/json/nullable_column.cpp Outdated Show resolved Hide resolved
sevev
sevev previously approved these changes Jul 22, 2024
View reviewed changes
@wyb wyb dismissed stale reviews from sevev and luohaha via 659b4d5 July 25, 2024 07:23
@wyb wyb enabled auto-merge (squash) July 25, 2024 09:19
@github-actions github-actions bot removed the 3.1 label Jul 25, 2024
@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 164 / 193 (84.97%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/formats/json/nullable_column.cpp 163 192 84.90% [134, 135, 145, 146, 147, 148, 177, 178, 179, 180, 194, 195, 196, 197, 212, 213, 214, 215, 314, 315, 316, 317, 348, 349, 350, 351, 418, 419, 443]
🔵 be/src/exec/json_scanner.cpp 1 1 100.00% []

@wyb wyb merged commit 47171f0 into StarRocks:main Jul 25, 2024
59 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Jul 25, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Jul 25, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 25, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 25, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 25, 2024
@wyb @mergify
[BugFix] Fix load boolean from json (#48387)
4b52bc4 
Signed-off-by: wyb <[email protected]>
(cherry picked from commit 47171f0)
@mergify mergify bot mentioned this pull request Jul 25, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Jul 25, 2024
@wyb @mergify
[BugFix] Fix load boolean from json (#48387)
d35f9f1 
Signed-off-by: wyb <[email protected]>
(cherry picked from commit 47171f0)

# Conflicts:
#	be/test/formats/json/nullable_column_test.cpp
@mergify mergify bot mentioned this pull request Jul 25, 2024
Closed
42 tasks
wyb added a commit to wyb/starrocks that referenced this pull request Jul 25, 2024
@wyb
[BugFix] Fix load boolean from json (StarRocks#48387)
2388595 
Signed-off-by: wyb <[email protected]>
@wyb wyb mentioned this pull request Jul 25, 2024
Merged
24 tasks
wanpengfei-git pushed a commit that referenced this pull request Jul 25, 2024
@mergify @wyb
[BugFix] Fix load boolean from json (backport #48387) (#48927)
277c7e0 
Co-authored-by: wyb <[email protected]>
luohaha pushed a commit that referenced this pull request Jul 25, 2024
@wyb
[BugFix] Fix load boolean from json (backport #48387) (#48929)
f43fba1 
Signed-off-by: wyb <[email protected]>
dujijun007 pushed a commit to dujijun007/starrocks that referenced this pull request Jul 29, 2024
@wyb @dujijun007
[BugFix] Fix load boolean from json (StarRocks#48387)
7068001 
Signed-off-by: wyb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banmoy banmoy banmoy approved these changes

@luohaha luohaha luohaha approved these changes

@meegoo meegoo meegoo approved these changes

@sevev sevev sevev left review comments

Assignees

@wyb wyb

Labels
3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wyb @meegoo @luohaha @banmoy @sevev