Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] configure S3 client rename_file operation timeout #48860

Merged
merged 5 commits into from
Aug 12, 2024
Merged

[Enhancement] configure S3 client rename_file operation timeout #48860

merged 5 commits into from
Aug 12, 2024

Commits on Aug 7, 2024

  1. [Enhancement] configure S3 client rename_file operation timeout 

    Why I'm doing:
Currently, sr use object_storage_request_timeout_ms as the S3 client request timeout. But this parameter maybe too small in some case especially using by rename_file operation for large file (1GB, for example). Timeout maybe happen in this case

What I'm doing:
We introduce a new BE/CN config called object_storage_rename_file_request_timeout_ms and it is used as following:
1. If object_storage_rename_file_request_timeout_ms >= 0, it will used for rename_file operation in S3 as the request timeout.
2. If object_storage_rename_file_request_timeout_ms < 0, the timeout limit for rename_file operation in S3 will be determinded by object_storage_request_timeout_ms.

Signed-off-by: srlch <[email protected]>
    @srlch
    srlch committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    24d7d52 View commit details
    Browse the repository at this point in the history

  2. Fix 

    Signed-off-by: srlch <[email protected]>
    @srlch
    srlch committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    9015834 View commit details
    Browse the repository at this point in the history

  3. fix ut 

    Signed-off-by: srlch <[email protected]>
    @srlch
    srlch committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    6ea02f0 View commit details
    Browse the repository at this point in the history

  4. fix 

    Signed-off-by: srlch <[email protected]>
    @srlch
    srlch committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    8f84b3e View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. fix be ut 

    Signed-off-by: srlch <[email protected]>
    @srlch
    srlch committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    1b53429 View commit details
    Browse the repository at this point in the history