Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] store query_id instead of start_task_run_id in task_run_history #48879

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

murphyatwork
Copy link
Contributor

@murphyatwork murphyatwork commented Jul 25, 2024

Why I'm doing:

What I'm doing:

  • we should store the query_id as task_run_id

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@murphyatwork murphyatwork enabled auto-merge (squash) July 25, 2024 02:44
@github-actions github-actions bot added the 3.3 label Jul 25, 2024
Signed-off-by: Murphy <[email protected]>
Copy link

sonarcloud bot commented Jul 25, 2024

Copy link

[FE Incremental Coverage Report]

pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/scheduler/history/TaskRunHistoryTable.java 1 1 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@murphyatwork murphyatwork merged commit 1523c65 into StarRocks:main Jul 25, 2024
59 of 62 checks passed
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Jul 25, 2024
Copy link
Contributor

mergify bot commented Jul 25, 2024

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 25, 2024
wanpengfei-git pushed a commit that referenced this pull request Jul 25, 2024
dujijun007 pushed a commit to dujijun007/starrocks that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants