[BugFix] Fix thrift rpc not reopen after failed #49619

stdpain · 2024-08-08T13:18:29Z

Why I'm doing:

When an error occurs on rpc. client->reopen needs to be called, otherwise client parsing will return to the connection pool. This causes other rpc's to fail.

    ~ClientConnection() {
        if (_client != nullptr) {
            _client_cache->release_client(&_client);
        }
    }

This programming model is very bad, but this PR needs backport. i will refactor the client cache related logic in the next PR.

What I'm doing:

Fixes case:

W0805 16:55:14.940848  1227 thrift_rpc_helper.cpp:86] call frontend service failed, address=TNetworkAddress(=****/), port=9020), reason=invalid TType

reproduce case:

apply this patch to FE

diff --git a/fe/fe-core/src/main/java/com/starrocks/common/Config.java b/fe/fe-core/src/main/java/com/starrocks/common/Config.java
index 750c9e759c..f45512f424 100644
--- a/fe/fe-core/src/main/java/com/starrocks/common/Config.java
+++ b/fe/fe-core/src/main/java/com/starrocks/common/Config.java
@@ -1303,6 +1303,9 @@ public class Config extends ConfigBase {
     @ConfField
     public static boolean enable_udf = false;
 
+    @ConfField(mutable = true)
+    public static int sleep_times = 30;
+
     @ConfField(mutable = true)
     public static boolean enable_decimal_v3 = true;
 
diff --git a/fe/fe-core/src/main/java/com/starrocks/service/FrontendServiceImpl.java b/fe/fe-core/src/main/java/com/starrocks/service/FrontendServiceImpl.java
index 5efbe38d83..af02ecbd7d 100644
--- a/fe/fe-core/src/main/java/com/starrocks/service/FrontendServiceImpl.java
+++ b/fe/fe-core/src/main/java/com/starrocks/service/FrontendServiceImpl.java
@@ -589,6 +589,13 @@ public class FrontendServiceImpl implements FrontendService.Iface {
         if (!params.isSetUser_ident()) {
             throw new TException("missed user_identity");
         }
+        if (Config.sleep_times > 0) {
+            try {
+                Thread.sleep(1000 * Config.sleep_times);
+            } catch (InterruptedException e) {
+                throw new RuntimeException(e);
+            }
+        }
         // TODO: check privilege
         UserIdentity userIdentity = UserIdentity.fromThrift(params.getUser_ident());
 
@@ -1146,6 +1153,13 @@ public class FrontendServiceImpl implements FrontendService.Iface {
 
     @Override
     public TReportExecStatusResult reportExecStatus(TReportExecStatusParams params) throws TException {
+        if (Config.sleep_times > 0) {
+            try {
+                Thread.sleep(1000 * Config.sleep_times);
+            } catch (InterruptedException e) {
+                throw new RuntimeException(e);
+            }
+        }
         return QeProcessorImpl.INSTANCE.reportExecStatus(params, getClientAddr());
     }

then send the query multi times.
we will see be:

W20240808 21:01:52.651160 139898530641472 pipeline_driver_executor.cpp:346] [Driver] Fail to report exec state: fragment_instance_id=38ad1356-5586-11ef-a78f-c26b621cd046, status: Internal erro
r: ReportExecStatus() to TNetworkAddress(hostname=172.17.0.1, port=8505) failed:
THRIFT_EAGAIN (timed out), retry_times=1
W20240808 21:01:52.789011 139897653958208 thrift_rpc_helper.cpp:135] Rpc error: FE RPC response parsing failure, address=TNetworkAddress(hostname=172.17.0.1, port=8505).The FE may be busy, ple
ase retry later
W20240808 21:01:52.789011 139897653958208 thrift_rpc_helper.cpp:135] Rpc error: FE RPC response parsing failure, address=TNetworkAddress(hostname=172.17.0.1, port=8505).The FE may be busy, ple
ase retry later

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
This is a backport pr

Bugfix cherry-pick branch check:

Documentation PRs only:

If you are submitting a PR that adds or changes English documentation and have not
included Chinese documentation, then you can check the box to request GPT to translate the
English doc to Chinese. Please ensure to uncheck the Do not translate box if translation is needed.
The workflow will generate a new PR with the Chinese translation after this PR is merged.

Yes, translate English markdown files with GPT
Do not translate

be/src/util/thrift_rpc_helper.cpp

Signed-off-by: stdpain <[email protected]>

github-actions · 2024-08-09T05:34:50Z

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-08-09T05:45:41Z

[BE Incremental Coverage Report]

❌ fail : 0 / 6 (00.00%)

file detail

	path	new_line	coverage	not_covered_line_detail
🔵	be/src/exec/pipeline/exec_state_reporter.cpp	2	00.00%	[195, 308]
🔵	be/src/runtime/fragment_mgr.cpp	2	00.00%	[345, 772]
🔵	be/src/exec/pipeline/audit_statistics_reporter.cpp	1	00.00%	[80]
🔵	be/src/exec/pipeline/query_context.cpp	1	00.00%	[679]

github-actions · 2024-08-09T06:17:47Z

@Mergifyio backport branch-3.3

github-actions · 2024-08-09T06:17:48Z

@Mergifyio backport branch-3.2

github-actions · 2024-08-09T06:17:50Z

@Mergifyio backport branch-3.1

github-actions · 2024-08-09T06:17:51Z

@Mergifyio backport branch-3.0

mergify · 2024-08-09T06:18:11Z

backport branch-3.3

✅ Backports have been created

#49644 [BugFix] Fix thrift rpc not reopen after failed (backport #49619) has been created for branch branch-3.3

mergify · 2024-08-09T06:18:12Z

backport branch-3.2

✅ Backports have been created

#49645 [BugFix] Fix thrift rpc not reopen after failed (backport #49619) has been created for branch branch-3.2

mergify · 2024-08-09T06:18:13Z

backport branch-3.1

✅ Backports have been created

#49646 [BugFix] Fix thrift rpc not reopen after failed (backport #49619) has been created for branch branch-3.1 but encountered conflicts

mergify · 2024-08-09T06:18:14Z

backport branch-3.0

✅ Backports have been created

#49647 [BugFix] Fix thrift rpc not reopen after failed (backport #49619) has been created for branch branch-3.0 but encountered conflicts

@OverRide

## Why I'm doing: When an error occurs on rpc. client->reopen needs to be called, otherwise client parsing will return to the connection pool. This causes other rpc's to fail. ``` ~ClientConnection() { if (_client != nullptr) { _client_cache->release_client(&_client); } } ``` This programming model is very bad, but this PR needs backport. i will refactor the client cache related logic in the next PR. ## What I'm doing: Fixes case: ``` W0805 16:55:14.940848 1227 thrift_rpc_helper.cpp:86] call frontend service failed, address=TNetworkAddress(=****/), port=9020), reason=invalid TType ``` reproduce case: apply this patch to FE ``` diff --git a/fe/fe-core/src/main/java/com/starrocks/common/Config.java b/fe/fe-core/src/main/java/com/starrocks/common/Config.java index 750c9e759c..f45512f424 100644 --- a/fe/fe-core/src/main/java/com/starrocks/common/Config.java +++ b/fe/fe-core/src/main/java/com/starrocks/common/Config.java @@ -1303,6 +1303,9 @@ public class Config extends ConfigBase { @ConfField public static boolean enable_udf = false; + @ConfField(mutable = true) + public static int sleep_times = 30; + @ConfField(mutable = true) public static boolean enable_decimal_v3 = true; diff --git a/fe/fe-core/src/main/java/com/starrocks/service/FrontendServiceImpl.java b/fe/fe-core/src/main/java/com/starrocks/service/FrontendServiceImpl.java index 5efbe38d83..af02ecbd7d 100644 --- a/fe/fe-core/src/main/java/com/starrocks/service/FrontendServiceImpl.java +++ b/fe/fe-core/src/main/java/com/starrocks/service/FrontendServiceImpl.java @@ -589,6 +589,13 @@ public class FrontendServiceImpl implements FrontendService.Iface { if (!params.isSetUser_ident()) { throw new TException("missed user_identity"); } + if (Config.sleep_times > 0) { + try { + Thread.sleep(1000 * Config.sleep_times); + } catch (InterruptedException e) { + throw new RuntimeException(e); + } + } // TODO: check privilege UserIdentity userIdentity = UserIdentity.fromThrift(params.getUser_ident()); @@ -1146,6 +1153,13 @@ public class FrontendServiceImpl implements FrontendService.Iface { @OverRide public TReportExecStatusResult reportExecStatus(TReportExecStatusParams params) throws TException { + if (Config.sleep_times > 0) { + try { + Thread.sleep(1000 * Config.sleep_times); + } catch (InterruptedException e) { + throw new RuntimeException(e); + } + } return QeProcessorImpl.INSTANCE.reportExecStatus(params, getClientAddr()); } ``` then send the query multi times. we will see be: ``` W20240808 21:01:52.651160 139898530641472 pipeline_driver_executor.cpp:346] [Driver] Fail to report exec state: fragment_instance_id=38ad1356-5586-11ef-a78f-c26b621cd046, status: Internal erro r: ReportExecStatus() to TNetworkAddress(hostname=172.17.0.1, port=8505) failed: THRIFT_EAGAIN (timed out), retry_times=1 W20240808 21:01:52.789011 139897653958208 thrift_rpc_helper.cpp:135] Rpc error: FE RPC response parsing failure, address=TNetworkAddress(hostname=172.17.0.1, port=8505).The FE may be busy, ple ase retry later W20240808 21:01:52.789011 139897653958208 thrift_rpc_helper.cpp:135] Rpc error: FE RPC response parsing failure, address=TNetworkAddress(hostname=172.17.0.1, port=8505).The FE may be busy, ple ase retry later ``` Signed-off-by: stdpain <[email protected]> (cherry picked from commit c8bd900)

@OverRide

## Why I'm doing: When an error occurs on rpc. client->reopen needs to be called, otherwise client parsing will return to the connection pool. This causes other rpc's to fail. ``` ~ClientConnection() { if (_client != nullptr) { _client_cache->release_client(&_client); } } ``` This programming model is very bad, but this PR needs backport. i will refactor the client cache related logic in the next PR. ## What I'm doing: Fixes case: ``` W0805 16:55:14.940848 1227 thrift_rpc_helper.cpp:86] call frontend service failed, address=TNetworkAddress(=****/), port=9020), reason=invalid TType ``` reproduce case: apply this patch to FE ``` diff --git a/fe/fe-core/src/main/java/com/starrocks/common/Config.java b/fe/fe-core/src/main/java/com/starrocks/common/Config.java index 750c9e759c..f45512f424 100644 --- a/fe/fe-core/src/main/java/com/starrocks/common/Config.java +++ b/fe/fe-core/src/main/java/com/starrocks/common/Config.java @@ -1303,6 +1303,9 @@ public class Config extends ConfigBase { @ConfField public static boolean enable_udf = false; + @ConfField(mutable = true) + public static int sleep_times = 30; + @ConfField(mutable = true) public static boolean enable_decimal_v3 = true; diff --git a/fe/fe-core/src/main/java/com/starrocks/service/FrontendServiceImpl.java b/fe/fe-core/src/main/java/com/starrocks/service/FrontendServiceImpl.java index 5efbe38d83..af02ecbd7d 100644 --- a/fe/fe-core/src/main/java/com/starrocks/service/FrontendServiceImpl.java +++ b/fe/fe-core/src/main/java/com/starrocks/service/FrontendServiceImpl.java @@ -589,6 +589,13 @@ public class FrontendServiceImpl implements FrontendService.Iface { if (!params.isSetUser_ident()) { throw new TException("missed user_identity"); } + if (Config.sleep_times > 0) { + try { + Thread.sleep(1000 * Config.sleep_times); + } catch (InterruptedException e) { + throw new RuntimeException(e); + } + } // TODO: check privilege UserIdentity userIdentity = UserIdentity.fromThrift(params.getUser_ident()); @@ -1146,6 +1153,13 @@ public class FrontendServiceImpl implements FrontendService.Iface { @OverRide public TReportExecStatusResult reportExecStatus(TReportExecStatusParams params) throws TException { + if (Config.sleep_times > 0) { + try { + Thread.sleep(1000 * Config.sleep_times); + } catch (InterruptedException e) { + throw new RuntimeException(e); + } + } return QeProcessorImpl.INSTANCE.reportExecStatus(params, getClientAddr()); } ``` then send the query multi times. we will see be: ``` W20240808 21:01:52.651160 139898530641472 pipeline_driver_executor.cpp:346] [Driver] Fail to report exec state: fragment_instance_id=38ad1356-5586-11ef-a78f-c26b621cd046, status: Internal erro r: ReportExecStatus() to TNetworkAddress(hostname=172.17.0.1, port=8505) failed: THRIFT_EAGAIN (timed out), retry_times=1 W20240808 21:01:52.789011 139897653958208 thrift_rpc_helper.cpp:135] Rpc error: FE RPC response parsing failure, address=TNetworkAddress(hostname=172.17.0.1, port=8505).The FE may be busy, ple ase retry later W20240808 21:01:52.789011 139897653958208 thrift_rpc_helper.cpp:135] Rpc error: FE RPC response parsing failure, address=TNetworkAddress(hostname=172.17.0.1, port=8505).The FE may be busy, ple ase retry later ``` Signed-off-by: stdpain <[email protected]> (cherry picked from commit c8bd900)

@OverRide

## Why I'm doing: When an error occurs on rpc. client->reopen needs to be called, otherwise client parsing will return to the connection pool. This causes other rpc's to fail. ``` ~ClientConnection() { if (_client != nullptr) { _client_cache->release_client(&_client); } } ``` This programming model is very bad, but this PR needs backport. i will refactor the client cache related logic in the next PR. ## What I'm doing: Fixes case: ``` W0805 16:55:14.940848 1227 thrift_rpc_helper.cpp:86] call frontend service failed, address=TNetworkAddress(=****/), port=9020), reason=invalid TType ``` reproduce case: apply this patch to FE ``` diff --git a/fe/fe-core/src/main/java/com/starrocks/common/Config.java b/fe/fe-core/src/main/java/com/starrocks/common/Config.java index 750c9e759c..f45512f424 100644 --- a/fe/fe-core/src/main/java/com/starrocks/common/Config.java +++ b/fe/fe-core/src/main/java/com/starrocks/common/Config.java @@ -1303,6 +1303,9 @@ public class Config extends ConfigBase { @ConfField public static boolean enable_udf = false; + @ConfField(mutable = true) + public static int sleep_times = 30; + @ConfField(mutable = true) public static boolean enable_decimal_v3 = true; diff --git a/fe/fe-core/src/main/java/com/starrocks/service/FrontendServiceImpl.java b/fe/fe-core/src/main/java/com/starrocks/service/FrontendServiceImpl.java index 5efbe38d83..af02ecbd7d 100644 --- a/fe/fe-core/src/main/java/com/starrocks/service/FrontendServiceImpl.java +++ b/fe/fe-core/src/main/java/com/starrocks/service/FrontendServiceImpl.java @@ -589,6 +589,13 @@ public class FrontendServiceImpl implements FrontendService.Iface { if (!params.isSetUser_ident()) { throw new TException("missed user_identity"); } + if (Config.sleep_times > 0) { + try { + Thread.sleep(1000 * Config.sleep_times); + } catch (InterruptedException e) { + throw new RuntimeException(e); + } + } // TODO: check privilege UserIdentity userIdentity = UserIdentity.fromThrift(params.getUser_ident()); @@ -1146,6 +1153,13 @@ public class FrontendServiceImpl implements FrontendService.Iface { @OverRide public TReportExecStatusResult reportExecStatus(TReportExecStatusParams params) throws TException { + if (Config.sleep_times > 0) { + try { + Thread.sleep(1000 * Config.sleep_times); + } catch (InterruptedException e) { + throw new RuntimeException(e); + } + } return QeProcessorImpl.INSTANCE.reportExecStatus(params, getClientAddr()); } ``` then send the query multi times. we will see be: ``` W20240808 21:01:52.651160 139898530641472 pipeline_driver_executor.cpp:346] [Driver] Fail to report exec state: fragment_instance_id=38ad1356-5586-11ef-a78f-c26b621cd046, status: Internal erro r: ReportExecStatus() to TNetworkAddress(hostname=172.17.0.1, port=8505) failed: THRIFT_EAGAIN (timed out), retry_times=1 W20240808 21:01:52.789011 139897653958208 thrift_rpc_helper.cpp:135] Rpc error: FE RPC response parsing failure, address=TNetworkAddress(hostname=172.17.0.1, port=8505).The FE may be busy, ple ase retry later W20240808 21:01:52.789011 139897653958208 thrift_rpc_helper.cpp:135] Rpc error: FE RPC response parsing failure, address=TNetworkAddress(hostname=172.17.0.1, port=8505).The FE may be busy, ple ase retry later ``` Signed-off-by: stdpain <[email protected]> (cherry picked from commit c8bd900) # Conflicts: # be/src/util/thrift_rpc_helper.cpp # be/test/util/thrift_rpc_helper_test.cpp

@OverRide

## Why I'm doing: When an error occurs on rpc. client->reopen needs to be called, otherwise client parsing will return to the connection pool. This causes other rpc's to fail. ``` ~ClientConnection() { if (_client != nullptr) { _client_cache->release_client(&_client); } } ``` This programming model is very bad, but this PR needs backport. i will refactor the client cache related logic in the next PR. ## What I'm doing: Fixes case: ``` W0805 16:55:14.940848 1227 thrift_rpc_helper.cpp:86] call frontend service failed, address=TNetworkAddress(=****/), port=9020), reason=invalid TType ``` reproduce case: apply this patch to FE ``` diff --git a/fe/fe-core/src/main/java/com/starrocks/common/Config.java b/fe/fe-core/src/main/java/com/starrocks/common/Config.java index 750c9e759c..f45512f424 100644 --- a/fe/fe-core/src/main/java/com/starrocks/common/Config.java +++ b/fe/fe-core/src/main/java/com/starrocks/common/Config.java @@ -1303,6 +1303,9 @@ public class Config extends ConfigBase { @ConfField public static boolean enable_udf = false; + @ConfField(mutable = true) + public static int sleep_times = 30; + @ConfField(mutable = true) public static boolean enable_decimal_v3 = true; diff --git a/fe/fe-core/src/main/java/com/starrocks/service/FrontendServiceImpl.java b/fe/fe-core/src/main/java/com/starrocks/service/FrontendServiceImpl.java index 5efbe38d83..af02ecbd7d 100644 --- a/fe/fe-core/src/main/java/com/starrocks/service/FrontendServiceImpl.java +++ b/fe/fe-core/src/main/java/com/starrocks/service/FrontendServiceImpl.java @@ -589,6 +589,13 @@ public class FrontendServiceImpl implements FrontendService.Iface { if (!params.isSetUser_ident()) { throw new TException("missed user_identity"); } + if (Config.sleep_times > 0) { + try { + Thread.sleep(1000 * Config.sleep_times); + } catch (InterruptedException e) { + throw new RuntimeException(e); + } + } // TODO: check privilege UserIdentity userIdentity = UserIdentity.fromThrift(params.getUser_ident()); @@ -1146,6 +1153,13 @@ public class FrontendServiceImpl implements FrontendService.Iface { @OverRide public TReportExecStatusResult reportExecStatus(TReportExecStatusParams params) throws TException { + if (Config.sleep_times > 0) { + try { + Thread.sleep(1000 * Config.sleep_times); + } catch (InterruptedException e) { + throw new RuntimeException(e); + } + } return QeProcessorImpl.INSTANCE.reportExecStatus(params, getClientAddr()); } ``` then send the query multi times. we will see be: ``` W20240808 21:01:52.651160 139898530641472 pipeline_driver_executor.cpp:346] [Driver] Fail to report exec state: fragment_instance_id=38ad1356-5586-11ef-a78f-c26b621cd046, status: Internal erro r: ReportExecStatus() to TNetworkAddress(hostname=172.17.0.1, port=8505) failed: THRIFT_EAGAIN (timed out), retry_times=1 W20240808 21:01:52.789011 139897653958208 thrift_rpc_helper.cpp:135] Rpc error: FE RPC response parsing failure, address=TNetworkAddress(hostname=172.17.0.1, port=8505).The FE may be busy, ple ase retry later W20240808 21:01:52.789011 139897653958208 thrift_rpc_helper.cpp:135] Rpc error: FE RPC response parsing failure, address=TNetworkAddress(hostname=172.17.0.1, port=8505).The FE may be busy, ple ase retry later ``` Signed-off-by: stdpain <[email protected]> (cherry picked from commit c8bd900) # Conflicts: # be/src/util/thrift_rpc_helper.cpp # be/test/util/thrift_rpc_helper_test.cpp

…9645) Co-authored-by: stdpain <[email protected]>

…9644) Co-authored-by: stdpain <[email protected]>

@OverRide

When an error occurs on rpc. client->reopen needs to be called, otherwise client parsing will return to the connection pool. This causes other rpc's to fail. ``` ~ClientConnection() { if (_client != nullptr) { _client_cache->release_client(&_client); } } ``` This programming model is very bad, but this PR needs backport. i will refactor the client cache related logic in the next PR. Fixes case: ``` W0805 16:55:14.940848 1227 thrift_rpc_helper.cpp:86] call frontend service failed, address=TNetworkAddress(=****/), port=9020), reason=invalid TType ``` reproduce case: apply this patch to FE ``` diff --git a/fe/fe-core/src/main/java/com/starrocks/common/Config.java b/fe/fe-core/src/main/java/com/starrocks/common/Config.java index 750c9e759c..f45512f424 100644 --- a/fe/fe-core/src/main/java/com/starrocks/common/Config.java +++ b/fe/fe-core/src/main/java/com/starrocks/common/Config.java @@ -1303,6 +1303,9 @@ public class Config extends ConfigBase { @ConfField public static boolean enable_udf = false; + @ConfField(mutable = true) + public static int sleep_times = 30; + @ConfField(mutable = true) public static boolean enable_decimal_v3 = true; diff --git a/fe/fe-core/src/main/java/com/starrocks/service/FrontendServiceImpl.java b/fe/fe-core/src/main/java/com/starrocks/service/FrontendServiceImpl.java index 5efbe38d83..af02ecbd7d 100644 --- a/fe/fe-core/src/main/java/com/starrocks/service/FrontendServiceImpl.java +++ b/fe/fe-core/src/main/java/com/starrocks/service/FrontendServiceImpl.java @@ -589,6 +589,13 @@ public class FrontendServiceImpl implements FrontendService.Iface { if (!params.isSetUser_ident()) { throw new TException("missed user_identity"); } + if (Config.sleep_times > 0) { + try { + Thread.sleep(1000 * Config.sleep_times); + } catch (InterruptedException e) { + throw new RuntimeException(e); + } + } // TODO: check privilege UserIdentity userIdentity = UserIdentity.fromThrift(params.getUser_ident()); @@ -1146,6 +1153,13 @@ public class FrontendServiceImpl implements FrontendService.Iface { @OverRide public TReportExecStatusResult reportExecStatus(TReportExecStatusParams params) throws TException { + if (Config.sleep_times > 0) { + try { + Thread.sleep(1000 * Config.sleep_times); + } catch (InterruptedException e) { + throw new RuntimeException(e); + } + } return QeProcessorImpl.INSTANCE.reportExecStatus(params, getClientAddr()); } ``` then send the query multi times. we will see be: ``` W20240808 21:01:52.651160 139898530641472 pipeline_driver_executor.cpp:346] [Driver] Fail to report exec state: fragment_instance_id=38ad1356-5586-11ef-a78f-c26b621cd046, status: Internal erro r: ReportExecStatus() to TNetworkAddress(hostname=172.17.0.1, port=8505) failed: THRIFT_EAGAIN (timed out), retry_times=1 W20240808 21:01:52.789011 139897653958208 thrift_rpc_helper.cpp:135] Rpc error: FE RPC response parsing failure, address=TNetworkAddress(hostname=172.17.0.1, port=8505).The FE may be busy, ple ase retry later W20240808 21:01:52.789011 139897653958208 thrift_rpc_helper.cpp:135] Rpc error: FE RPC response parsing failure, address=TNetworkAddress(hostname=172.17.0.1, port=8505).The FE may be busy, ple ase retry later ``` Signed-off-by: stdpain <[email protected]> (cherry picked from commit c8bd900) Signed-off-by: stdpain <[email protected]>

…9646) Signed-off-by: stdpain <[email protected]> Co-authored-by: stdpain <[email protected]>

stdpain requested review from a team as code owners August 8, 2024 13:18

github-actions bot added 3.3 3.2 3.1 3.0 labels Aug 8, 2024

mergify bot assigned stdpain Aug 8, 2024

Seaven previously approved these changes Aug 8, 2024

View reviewed changes

murphyatwork previously approved these changes Aug 8, 2024

View reviewed changes

wyb reviewed Aug 8, 2024

View reviewed changes

be/src/util/thrift_rpc_helper.cpp Outdated Show resolved Hide resolved

kevincai previously approved these changes Aug 8, 2024

View reviewed changes

stdpain dismissed stale reviews from kevincai, murphyatwork, and Seaven via 6eaacca August 9, 2024 01:57

stdpain force-pushed the fix_thrift_rpc_failed branch 2 times, most recently from 6eaacca to 9c9deda Compare August 9, 2024 02:00

wyb previously approved these changes Aug 9, 2024

View reviewed changes

[BugFix] Fix thrift rpc not reopen after failed

1cc15dd

Signed-off-by: stdpain <[email protected]>

stdpain dismissed wyb’s stale review via 1cc15dd August 9, 2024 03:52

stdpain force-pushed the fix_thrift_rpc_failed branch from 9c9deda to 1cc15dd Compare August 9, 2024 03:52

alvin-celerdata merged commit c8bd900 into StarRocks:main Aug 9, 2024
40 of 41 checks passed

github-actions bot removed 3.3 3.2 labels Aug 9, 2024

github-actions bot removed the 3.1 label Aug 9, 2024

github-actions bot removed the 3.0 label Aug 9, 2024

mergify bot mentioned this pull request Aug 9, 2024

[BugFix] Fix thrift rpc not reopen after failed (backport #49619) #49644

Merged

44 tasks

This was referenced Aug 9, 2024

[BugFix] Fix thrift rpc not reopen after failed (backport #49619) #49645

Merged

[BugFix] Fix thrift rpc not reopen after failed (backport #49619) #49646

Merged

mergify bot mentioned this pull request Aug 9, 2024

[BugFix] Fix thrift rpc not reopen after failed (backport #49619) #49647

Closed

44 tasks

wanpengfei-git pushed a commit that referenced this pull request Aug 9, 2024

[BugFix] Fix thrift rpc not reopen after failed (backport #49619) (#4…

75354cb

…9645) Co-authored-by: stdpain <[email protected]>

wanpengfei-git pushed a commit that referenced this pull request Aug 9, 2024

[BugFix] Fix thrift rpc not reopen after failed (backport #49619) (#4…

1497f8a

…9644) Co-authored-by: stdpain <[email protected]>

github-actions bot added 3.2-merged 3.3-merged labels Aug 9, 2024

wanpengfei-git pushed a commit that referenced this pull request Aug 19, 2024

[BugFix] Fix thrift rpc not reopen after failed (backport #49619) (#4…

b6f0072

…9646) Signed-off-by: stdpain <[email protected]> Co-authored-by: stdpain <[email protected]>

github-actions bot added the 3.1-merged label Aug 19, 2024

stdpain mentioned this pull request Aug 26, 2024

[BugFix] Fix thrift invalid TType error #50276

Merged

24 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BugFix] Fix thrift rpc not reopen after failed #49619

[BugFix] Fix thrift rpc not reopen after failed #49619

stdpain commented Aug 8, 2024 •

edited

Loading

github-actions bot commented Aug 9, 2024

github-actions bot commented Aug 9, 2024

github-actions bot commented Aug 9, 2024

github-actions bot commented Aug 9, 2024

github-actions bot commented Aug 9, 2024

github-actions bot commented Aug 9, 2024

mergify bot commented Aug 9, 2024 •

edited

Loading

mergify bot commented Aug 9, 2024 •

edited

Loading

mergify bot commented Aug 9, 2024 •

edited

Loading

mergify bot commented Aug 9, 2024 •

edited

Loading

[BugFix] Fix thrift rpc not reopen after failed #49619

[BugFix] Fix thrift rpc not reopen after failed #49619

Conversation

stdpain commented Aug 8, 2024 • edited Loading

Why I'm doing:

What I'm doing:

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

Documentation PRs only:

github-actions bot commented Aug 9, 2024

[FE Incremental Coverage Report]

github-actions bot commented Aug 9, 2024

[BE Incremental Coverage Report]

file detail

github-actions bot commented Aug 9, 2024

github-actions bot commented Aug 9, 2024

github-actions bot commented Aug 9, 2024

github-actions bot commented Aug 9, 2024

mergify bot commented Aug 9, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Aug 9, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Aug 9, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Aug 9, 2024 • edited Loading

✅ Backports have been created

stdpain commented Aug 8, 2024 •

edited

Loading

mergify bot commented Aug 9, 2024 •

edited

Loading

mergify bot commented Aug 9, 2024 •

edited

Loading

mergify bot commented Aug 9, 2024 •

edited

Loading

mergify bot commented Aug 9, 2024 •

edited

Loading