[Enhancement] Compatibility fix for RecyclePartitionInfo and AlterJobV2 #49636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
fe/fe-core/src/main/java/com/starrocks/alter/ForwardCompatibleAlterJobV2Object.java
Show resolved
Hide resolved
kevincai
force-pushed
the
compatibility-fix
branch
3 times, most recently
from
2f99b01
to
1dd73ba
Compare
kevincai
force-pushed
the
compatibility-fix
branch
from
1dd73ba
to
16458a6
Compare
gengjun-git
reviewed
Aug 12, 2024
fe/fe-core/src/main/java/com/starrocks/persist/gson/RuntimeTypeAdapterFactory.java
Show resolved
Hide resolved
kevincai
force-pushed
the
compatibility-fix
branch
from
16458a6
to
13fb778
Compare
gengjun-git
previously approved these changes
Aug 12, 2024
24 tasks
…AlterJobV2 * `RuntimeTypeAdapterFactory` allows registering a subtype as the fallback type if a class can't be recognized during deserialization * `ForwardCompatibleRecyclePartitionInfoV2` is added as the fallback subtype for `RecyclePartitionInfoV2` * `ForwardCompatibleAlterJobV2Object` is added as the fallback subtype for `AlterJobV2` * Update `AlterJobMgr/CatalogRecycleBin` accordingly to ignore the ForwardCompatible objects Signed-off-by: Kevin Xiaohua Cai <[email protected]>
Signed-off-by: Kevin Xiaohua Cai <[email protected]>
kevincai
force-pushed
the
compatibility-fix
branch
from
13fb778
to
804e86e
Compare
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 37 / 39 (94.87%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
gengjun-git
approved these changes
Aug 20, 2024
nshangyiming
approved these changes
Aug 20, 2024
wyb
approved these changes
Aug 20, 2024
|
@Mergifyio backport branch-3.3 |
|
@Mergifyio backport branch-3.2 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 20, 2024
…V2 (#49636) Signed-off-by: Kevin Xiaohua Cai <[email protected]> (cherry picked from commit 3cfcd6a)
Merged
44 tasks
mergify bot
pushed a commit
that referenced
this pull request
Aug 20, 2024
…V2 (#49636) Signed-off-by: Kevin Xiaohua Cai <[email protected]> (cherry picked from commit 3cfcd6a) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/catalog/CatalogRecycleBin.java # fe/fe-core/src/main/java/com/starrocks/persist/gson/GsonUtils.java
Merged
44 tasks
kevincai
added a commit
that referenced
this pull request
Aug 21, 2024
…V2 (#49636) Signed-off-by: Kevin Xiaohua Cai <[email protected]> (cherry picked from commit 3cfcd6a)
wanpengfei-git
pushed a commit
that referenced
this pull request
Aug 21, 2024
…V2 (backport #49636) (#50026) Co-authored-by: Kevin Cai <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Aug 23, 2024
…V2 (backport #49636) (#50027) Signed-off-by: Kevin Xiaohua Cai <[email protected]> Co-authored-by: Kevin Cai <[email protected]>
gengjun-git
added a commit
to gengjun-git/starrocks
that referenced
this pull request
Aug 26, 2024
…AlterJobV2 (StarRocks#49636)" This reverts commit 3cfcd6a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
RuntimeTypeAdapterFactoryallows registering a subtype as the fallbacktype if a class can't be recognized during deserialization
ForwardCompatibleRecyclePartitionInfoV2is added as the fallbacksubtype for
RecyclePartitionInfoV2ForwardCompatibleAlterJobV2Objectis added as the fallback subtype forAlterJobV2AlterJobMgr/CatalogRecycleBinaccordingly to ignore theForwardCompatible objects
Fixes #49680
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
Documentation PRs only:
If you are submitting a PR that adds or changes English documentation and have not
included Chinese documentation, then you can check the box to request GPT to translate the
English doc to Chinese. Please ensure to uncheck the Do not translate box if translation is needed.
The workflow will generate a new PR with the Chinese translation after this PR is merged.