Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] configure S3 client rename_file operation timeout (backport #48860) #49706

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 12, 2024

Why I'm doing:

Currently, sr use object_storage_request_timeout_ms as the S3 client request timeout. But this parameter maybe too small in some case especially using by rename_file operation for large file (1GB, for example). Timeout maybe happen in this case

What I'm doing:

We introduce a new BE/CN config called object_storage_rename_file_request_timeout_ms and it is used as following:

  1. If object_storage_rename_file_request_timeout_ms >= 0, it will used for rename_file operation in S3 as the request timeout.
  2. If object_storage_rename_file_request_timeout_ms < 0, the timeout limit for rename_file operation in S3 will be determinded by object_storage_request_timeout_ms.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #48860 done by [Mergify](https://mergify.com). ## Why I'm doing: Currently, sr use object_storage_request_timeout_ms as the S3 client request timeout. But this parameter maybe too small in some case especially using by rename_file operation for large file (1GB, for example). Timeout maybe happen in this case

What I'm doing:

We introduce a new BE/CN config called object_storage_rename_file_request_timeout_ms and it is used as following:

  1. If object_storage_rename_file_request_timeout_ms >= 0, it will used for rename_file operation in S3 as the request timeout.
  2. If object_storage_rename_file_request_timeout_ms < 0, the timeout limit for rename_file operation in S3 will be determinded by object_storage_request_timeout_ms.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

@wanpengfei-git wanpengfei-git merged commit 348c134 into branch-3.3 Aug 12, 2024
32 of 33 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.3/pr-48860 branch August 12, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants