[Enhancement] Optimize error message in csv scanner #49713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaogoy
reviewed
Aug 12, 2024
be/src/exec/csv_scanner.cpp
Outdated
| @@ -59,7 +59,8 @@ static std::string make_value_type_not_matched_error_message(int field_pos, cons | |||
| const SlotDescriptor* slot) { | |||
| std::stringstream error_msg; | |||
| error_msg << "The field (name = " << slot->col_name() << ", pos = " << field_pos << ") is out of range. " | |||
| << "Type: " << slot->type().debug_string() << ", Value: " << field.to_string(); | |||
| << "Type: " << slot->type().debug_string() << ", Value: " << field.to_string() | |||
| << ", Value length: " << field.get_size(); | |||
There was a problem hiding this comment.
it's better to put length first, when string is long
There was a problem hiding this comment.
if it's not a string, will the length be primted?
There was a problem hiding this comment.
changed to put length first.
if it's not a string, it also has length
Signed-off-by: xiangguangyxg <[email protected]>
xiangguangyxg
force-pushed
the
fix_tracking_logs
branch
from
aea437c
to
d58ef58
Compare
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]❌ fail : 0 / 2 (00.00%) file detail
|
wyb
approved these changes
Aug 19, 2024
sevev
approved these changes
Aug 19, 2024
|
@Mergifyio backport branch-3.3 |
|
@Mergifyio backport branch-3.2 |
|
@Mergifyio backport branch-3.1 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
Signed-off-by: xiangguangyxg <[email protected]> (cherry picked from commit 92748b8)
44 tasks
mergify bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
Signed-off-by: xiangguangyxg <[email protected]> (cherry picked from commit 92748b8) # Conflicts: # be/src/exec/csv_scanner.cpp
mergify bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
Signed-off-by: xiangguangyxg <[email protected]> (cherry picked from commit 92748b8)
This was referenced Aug 19, 2024
wanpengfei-git
pushed a commit
that referenced
this pull request
Aug 19, 2024
…#49970) Co-authored-by: xiangguangyxg <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Aug 23, 2024
…#49969) Co-authored-by: xiangguangyxg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Some error message in csv scanner is not clear enough.
What I'm doing:
Optimize error message in csv scanner
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
Documentation PRs only:
If you are submitting a PR that adds or changes English documentation and have not
included Chinese documentation, then you can check the box to request GPT to translate the
English doc to Chinese. Please ensure to uncheck the Do not translate box if translation is needed.
The workflow will generate a new PR with the Chinese translation after this PR is merged.