[BugFix] Fix replace temp partition bug for multi column partition table #49764

gengjun-git · 2024-08-13T09:25:53Z

Why I'm doing:

There will be a shadow partition for auto-create partition table, but for multi column partition table, it should be put into idToMultiValues.

What I'm doing:

Create the shadow partition according to isMultiColumnPartition();

Fixes

 com.starrocks.journal.JournalInconsistentException: failed to load journal type 210
        at com.starrocks.persist.EditLog.loadJournal(EditLog.java:1195)
        at com.starrocks.server.GlobalStateMgr.replayJournalInner(GlobalStateMgr.java:1879)
        at com.starrocks.server.GlobalStateMgr.replayJournal(GlobalStateMgr.java:1828)
        at com.starrocks.server.GlobalStateMgr.transferToLeader(GlobalStateMgr.java:1190)
        at com.starrocks.server.GlobalStateMgr$1.transferToLeader(GlobalStateMgr.java:732)
        at com.starrocks.ha.StateChangeExecutor.runOneCycle(StateChangeExecutor.java:103)
        at com.starrocks.common.util.Daemon.run(Daemon.java:107)
Caused by: java.lang.NullPointerException
        at com.starrocks.catalog.CatalogUtils.checkTempPartitionConflict(CatalogUtils.java:217)
        at com.starrocks.catalog.OlapTable.replaceTempPartitions(OlapTable.java:2644)
        at com.starrocks.server.LocalMetastore.replayReplaceTempPartition(LocalMetastore.java:4724)
        at com.starrocks.persist.EditLog.loadJournal(EditLog.java:834)

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
This is a backport pr

Bugfix cherry-pick branch check:

Documentation PRs only:

If you are submitting a PR that adds or changes English documentation and have not
included Chinese documentation, then you can check the box to request GPT to translate the
English doc to Chinese. Please ensure to uncheck the Do not translate box if translation is needed.
The workflow will generate a new PR with the Chinese translation after this PR is merged.

Yes, translate English markdown files with GPT
Do not translate

murphyatwork · 2024-08-13T11:27:55Z

fe/fe-core/src/main/java/com/starrocks/catalog/CatalogUtils.java

-                    itemList.forEach(item -> {
-                        cur.add(item.getRealObjectValue());
-                    });
+                    itemList.forEach(item -> cur.add(item.getRealObjectValue()));


can you just use the stream.map ? this is weird

gengjun-git · 2024-08-15T11:19:54Z

@Mergifyio rebase

Signed-off-by: gengjun-git <[email protected]>

mergify · 2024-08-15T11:20:19Z

rebase

✅ Branch has been successfully rebased

Signed-off-by: gengjun-git <[email protected]>

sonarcloud · 2024-08-16T03:03:30Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2024-08-16T04:33:25Z

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-08-16T04:34:06Z

[FE Incremental Coverage Report]

✅ pass : 19 / 20 (95.00%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/catalog/ListPartitionInfo.java	6	7	85.71%	[615]
🔵	com/starrocks/catalog/CatalogUtils.java	13	13	100.00%	[]

github-actions · 2024-08-16T04:34:14Z

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-08-16T06:24:57Z

@Mergifyio backport branch-3.3

github-actions · 2024-08-16T06:24:59Z

@Mergifyio backport branch-3.2

github-actions · 2024-08-16T06:25:00Z

@Mergifyio backport branch-3.1

github-actions · 2024-08-16T06:25:02Z

@Mergifyio backport branch-3.0

mergify · 2024-08-16T06:25:05Z

backport branch-3.3

✅ Backports have been created

#49896 [BugFix] Fix replace temp partition bug for multi column partition table (backport #49764) has been created for branch branch-3.3 but encountered conflicts

mergify · 2024-08-16T06:25:06Z

backport branch-3.2

✅ Backports have been created

#49897 [BugFix] Fix replace temp partition bug for multi column partition table (backport #49764) has been created for branch branch-3.2 but encountered conflicts

mergify · 2024-08-16T06:25:07Z

backport branch-3.1

✅ Backports have been created

#49898 [BugFix] Fix replace temp partition bug for multi column partition table (backport #49764) has been created for branch branch-3.1 but encountered conflicts

mergify · 2024-08-16T06:25:08Z

backport branch-3.0

✅ Backports have been created

#49899 [BugFix] Fix replace temp partition bug for multi column partition table (backport #49764) has been created for branch branch-3.0 but encountered conflicts

…ble (#49764) ## Why I'm doing: There will be a shadow partition for auto-create partition table, but for multi column partition table, it should be put into idToMultiValues. ## What I'm doing: Create the shadow partition according to isMultiColumnPartition(); Fixes ``` com.starrocks.journal.JournalInconsistentException: failed to load journal type 210 at com.starrocks.persist.EditLog.loadJournal(EditLog.java:1195) at com.starrocks.server.GlobalStateMgr.replayJournalInner(GlobalStateMgr.java:1879) at com.starrocks.server.GlobalStateMgr.replayJournal(GlobalStateMgr.java:1828) at com.starrocks.server.GlobalStateMgr.transferToLeader(GlobalStateMgr.java:1190) at com.starrocks.server.GlobalStateMgr$1.transferToLeader(GlobalStateMgr.java:732) at com.starrocks.ha.StateChangeExecutor.runOneCycle(StateChangeExecutor.java:103) at com.starrocks.common.util.Daemon.run(Daemon.java:107) Caused by: java.lang.NullPointerException at com.starrocks.catalog.CatalogUtils.checkTempPartitionConflict(CatalogUtils.java:217) at com.starrocks.catalog.OlapTable.replaceTempPartitions(OlapTable.java:2644) at com.starrocks.server.LocalMetastore.replayReplaceTempPartition(LocalMetastore.java:4724) at com.starrocks.persist.EditLog.loadJournal(EditLog.java:834) ``` Signed-off-by: gengjun-git <[email protected]> (cherry picked from commit 4c585a7) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/catalog/ListPartitionInfo.java

…ble (backport #49764) (#49898) Signed-off-by: gengjun-git <[email protected]> Co-authored-by: gengjun-git <[email protected]>

…ble (backport #49764) (#49896) Signed-off-by: gengjun-git <[email protected]> Co-authored-by: gengjun-git <[email protected]>

…ble (backport #49764) (#49897) Signed-off-by: gengjun-git <[email protected]> Co-authored-by: gengjun-git <[email protected]>

gengjun-git requested review from a team as code owners August 13, 2024 09:25

github-actions bot added the 3.3 label Aug 13, 2024

mergify bot assigned gengjun-git Aug 13, 2024

github-actions bot added 3.2 3.1 3.0 labels Aug 13, 2024

nshangyiming previously approved these changes Aug 13, 2024

View reviewed changes

murphyatwork reviewed Aug 13, 2024

View reviewed changes

gengjun-git dismissed nshangyiming’s stale review via 352aa47 August 13, 2024 12:50

gengjun-git added 3 commits August 15, 2024 11:20

fix

7f06816

Signed-off-by: gengjun-git <[email protected]>

fix

14434f0

Signed-off-by: gengjun-git <[email protected]>

fix

2c39dd8

Signed-off-by: gengjun-git <[email protected]>

gengjun-git force-pushed the fix_multi_column_partition_replace_bug branch from d9b2e96 to 2c39dd8 Compare August 15, 2024 11:20

gengjun-git enabled auto-merge (squash) August 15, 2024 13:16

murphyatwork previously approved these changes Aug 16, 2024

View reviewed changes

add test

863d998

Signed-off-by: gengjun-git <[email protected]>

gengjun-git dismissed murphyatwork’s stale review via 863d998 August 16, 2024 02:56

murphyatwork approved these changes Aug 16, 2024

View reviewed changes

meegoo approved these changes Aug 16, 2024

View reviewed changes

HangyuanLiu approved these changes Aug 16, 2024

View reviewed changes

gengjun-git merged commit 4c585a7 into StarRocks:main Aug 16, 2024
49 checks passed

github-actions bot removed the 3.3 label Aug 16, 2024

github-actions bot removed the 3.2 label Aug 16, 2024

github-actions bot removed the 3.1 label Aug 16, 2024

github-actions bot removed the 3.0 label Aug 16, 2024

mergify bot mentioned this pull request Aug 16, 2024

[BugFix] Fix replace temp partition bug for multi column partition table (backport #49764) #49896

Merged

44 tasks

This was referenced Aug 16, 2024

[BugFix] Fix replace temp partition bug for multi column partition table (backport #49764) #49897

Merged

[BugFix] Fix replace temp partition bug for multi column partition table (backport #49764) #49898

Merged

mergify bot mentioned this pull request Aug 16, 2024

[BugFix] Fix replace temp partition bug for multi column partition table (backport #49764) #49899

Closed

44 tasks

github-actions bot added 3.3 3.2 3.1 labels Aug 19, 2024

wanpengfei-git pushed a commit that referenced this pull request Aug 19, 2024

[BugFix] Fix replace temp partition bug for multi column partition ta…

9a4ae82

…ble (backport #49764) (#49898) Signed-off-by: gengjun-git <[email protected]> Co-authored-by: gengjun-git <[email protected]>

github-actions bot added the 3.1-merged label Aug 19, 2024

wanpengfei-git pushed a commit that referenced this pull request Aug 22, 2024

[BugFix] Fix replace temp partition bug for multi column partition ta…

777f187

…ble (backport #49764) (#49896) Signed-off-by: gengjun-git <[email protected]> Co-authored-by: gengjun-git <[email protected]>

github-actions bot added the 3.3-merged label Aug 22, 2024

wanpengfei-git pushed a commit that referenced this pull request Aug 23, 2024

[BugFix] Fix replace temp partition bug for multi column partition ta…

26e0515

…ble (backport #49764) (#49897) Signed-off-by: gengjun-git <[email protected]> Co-authored-by: gengjun-git <[email protected]>

github-actions bot added the 3.2-merged label Aug 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BugFix] Fix replace temp partition bug for multi column partition table #49764

[BugFix] Fix replace temp partition bug for multi column partition table #49764

gengjun-git commented Aug 13, 2024 •

edited

Loading

murphyatwork Aug 13, 2024

gengjun-git commented Aug 15, 2024

mergify bot commented Aug 15, 2024

sonarcloud bot commented Aug 16, 2024

github-actions bot commented Aug 16, 2024

github-actions bot commented Aug 16, 2024

github-actions bot commented Aug 16, 2024

github-actions bot commented Aug 16, 2024

github-actions bot commented Aug 16, 2024

github-actions bot commented Aug 16, 2024

github-actions bot commented Aug 16, 2024

mergify bot commented Aug 16, 2024 •

edited

Loading

mergify bot commented Aug 16, 2024 •

edited

Loading

mergify bot commented Aug 16, 2024 •

edited

Loading

mergify bot commented Aug 16, 2024 •

edited

Loading

[BugFix] Fix replace temp partition bug for multi column partition table #49764

[BugFix] Fix replace temp partition bug for multi column partition table #49764

Conversation

gengjun-git commented Aug 13, 2024 • edited Loading

Why I'm doing:

What I'm doing:

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

Documentation PRs only:

murphyatwork Aug 13, 2024

Choose a reason for hiding this comment

gengjun-git commented Aug 15, 2024

mergify bot commented Aug 15, 2024

✅ Branch has been successfully rebased

sonarcloud bot commented Aug 16, 2024

Quality Gate passed

github-actions bot commented Aug 16, 2024

[Java-Extensions Incremental Coverage Report]

github-actions bot commented Aug 16, 2024

[FE Incremental Coverage Report]

file detail

github-actions bot commented Aug 16, 2024

[BE Incremental Coverage Report]

github-actions bot commented Aug 16, 2024

github-actions bot commented Aug 16, 2024

github-actions bot commented Aug 16, 2024

github-actions bot commented Aug 16, 2024

mergify bot commented Aug 16, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Aug 16, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Aug 16, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Aug 16, 2024 • edited Loading

✅ Backports have been created

gengjun-git commented Aug 13, 2024 •

edited

Loading

mergify bot commented Aug 16, 2024 •

edited

Loading

mergify bot commented Aug 16, 2024 •

edited

Loading

mergify bot commented Aug 16, 2024 •

edited

Loading

mergify bot commented Aug 16, 2024 •

edited

Loading