Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support describe files() #50527

Merged
merged 3 commits into from
Sep 10, 2024
Merged

[Enhancement] Support describe files() #50527

merged 3 commits into from
Sep 10, 2024

Conversation

wyb
Copy link
Contributor

@wyb wyb commented Sep 2, 2024

Why I'm doing:

before this pr, user can get files schema by create table tbl as select * from files(), and desc tbl

What I'm doing:

support desc files() to get files schema

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@wyb wyb requested review from a team as code owners September 2, 2024 01:44
@mergify mergify bot assigned wyb Sep 2, 2024
@wyb
Copy link
Contributor Author

wyb commented Sep 9, 2024

@Mergifyio rebase

Copy link
Contributor

mergify bot commented Sep 9, 2024

rebase

❌ Unable to rebase: user wyb is unknown.

Please make sure wyb has logged in Mergify dashboard.

Copy link

sonarcloud bot commented Sep 9, 2024

Copy link

github-actions bot commented Sep 9, 2024

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Sep 9, 2024

[FE Incremental Coverage Report]

pass : 43 / 46 (93.48%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/common/SchemaConstants.java 0 1 00.00% [17]
🔵 com/starrocks/sql/analyzer/ShowStmtAnalyzer.java 17 19 89.47% [346, 347]
🔵 com/starrocks/common/proc/IndexSchemaProcNode.java 1 1 100.00% []
🔵 com/starrocks/sql/ast/DescribeStmt.java 18 18 100.00% []
🔵 com/starrocks/sql/analyzer/AuthorizerStmtVisitor.java 2 2 100.00% []
🔵 com/starrocks/connector/jdbc/PostgresSchemaResolver.java 1 1 100.00% []
🔵 com/starrocks/connector/jdbc/JDBCSchemaResolver.java 1 1 100.00% []
🔵 com/starrocks/connector/jdbc/OracleSchemaResolver.java 1 1 100.00% []
🔵 com/starrocks/qe/ShowExecutor.java 2 2 100.00% []

Copy link

github-actions bot commented Sep 9, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@wyb wyb enabled auto-merge (squash) September 10, 2024 02:44
@wyb wyb merged commit 34bd0d3 into StarRocks:main Sep 10, 2024
50 checks passed
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Sep 10, 2024
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Sep 10, 2024
Copy link
Contributor

mergify bot commented Sep 10, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Sep 10, 2024

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 10, 2024
Signed-off-by: wyb <[email protected]>
(cherry picked from commit 34bd0d3)
mergify bot pushed a commit that referenced this pull request Sep 10, 2024
Signed-off-by: wyb <[email protected]>
(cherry picked from commit 34bd0d3)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/connector/jdbc/JDBCSchemaResolver.java
#	fe/fe-core/src/main/java/com/starrocks/qe/ShowExecutor.java
#	test/sql/test_files/R/csv_format
#	test/sql/test_files/T/csv_format
@github-actions github-actions bot added the 3.3 label Sep 10, 2024
HangyuanLiu pushed a commit to HangyuanLiu/starrocks that referenced this pull request Sep 12, 2024
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants