Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix the disk size stats of rowset #50669

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

trueeyu
Copy link
Contributor

@trueeyu trueeyu commented Sep 4, 2024

Why I'm doing:

    // calculated by index + data
    optional int64 total_disk_size = 12;
    // calculated sum(segmentgroup.data_size)
    optional int64 data_disk_size = 13;
    // calculated sum(segmentgroup.index_size)
    optional int64 index_disk_size = 14;

total_disk_size = data_disk_size + index_disk_size

What I'm doing:

When some indexes are created on the table, there will be errors in rowset disk space statistics, which can lead to generate some large files.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@trueeyu trueeyu requested review from a team as code owners September 4, 2024 04:16
@trueeyu trueeyu changed the title [BugFix] Fix the disk size stats of Rowset [BugFix] Fix the disk size stats of rowset Sep 4, 2024
@mergify mergify bot assigned trueeyu Sep 4, 2024
@wyb wyb enabled auto-merge (squash) September 4, 2024 05:10
Copy link

github-actions bot commented Sep 4, 2024

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Sep 4, 2024

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Sep 4, 2024

[BE Incremental Coverage Report]

pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/rowset/rowset_writer.cpp 1 1 100.00% []

@wyb wyb merged commit ca4ff77 into StarRocks:main Sep 4, 2024
52 of 53 checks passed
@trueeyu
Copy link
Contributor Author

trueeyu commented Sep 11, 2024

@Mergifyio backport branch-3.3

@trueeyu
Copy link
Contributor Author

trueeyu commented Sep 11, 2024

@Mergifyio backport branch-3.2

Copy link
Contributor

mergify bot commented Sep 11, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Sep 11, 2024

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 11, 2024
Signed-off-by: trueeyu <[email protected]>
(cherry picked from commit ca4ff77)
mergify bot pushed a commit that referenced this pull request Sep 11, 2024
Signed-off-by: trueeyu <[email protected]>
(cherry picked from commit ca4ff77)
wanpengfei-git pushed a commit that referenced this pull request Sep 18, 2024
wanpengfei-git pushed a commit that referenced this pull request Sep 19, 2024
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants