Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] fix pipe deadlock in case of error #50841

Merged
merged 1 commit into from
Sep 10, 2024
Merged

[BugFix] fix pipe deadlock in case of error #50841

merged 1 commit into from
Sep 10, 2024

Conversation

murphyatwork
Copy link
Contributor

@murphyatwork murphyatwork commented Sep 9, 2024 •
edited
Loading

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@murphyatwork
fix deadlock
ca9af66 
Signed-off-by: Murphy <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

[FE Incremental Coverage Report]

✅ pass : 4 / 4 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/load/pipe/Pipe.java 4 4 100.00% []

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@murphyatwork murphyatwork enabled auto-merge (squash) September 10, 2024 05:28
@murphyatwork murphyatwork merged commit d207228 into StarRocks:main Sep 10, 2024
52 of 53 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 10, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 10, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 10, 2024
@murphyatwork @mergify
[BugFix] fix pipe deadlock in case of error (#50841)
06a4a0b 
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit d207228)
@mergify mergify bot mentioned this pull request Sep 10, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Sep 10, 2024
@murphyatwork @mergify
[BugFix] fix pipe deadlock in case of error (#50841)
c801344 
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit d207228)
@mergify mergify bot mentioned this pull request Sep 10, 2024
Merged
42 tasks
HangyuanLiu pushed a commit to HangyuanLiu/starrocks that referenced this pull request Sep 12, 2024
@murphyatwork @HangyuanLiu
[BugFix] fix pipe deadlock in case of error (StarRocks#50841)
5b83ecd 
Signed-off-by: Murphy <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Sep 27, 2024
@mergify @murphyatwork
[BugFix] fix pipe deadlock in case of error (backport #50841) (#50907)
91a9de0 
Co-authored-by: Murphy <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Oct 9, 2024
@mergify @murphyatwork
[BugFix] fix pipe deadlock in case of error (backport #50841) (#50905)
b8d583c 
Co-authored-by: Murphy <[email protected]>
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
@murphyatwork @renzhimin7
[BugFix] fix pipe deadlock in case of error (StarRocks#50841)
f5a3603 
Signed-off-by: Murphy <[email protected]>
Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengjun-git gengjun-git gengjun-git approved these changes

@wyb wyb wyb approved these changes

Assignees

@murphyatwork murphyatwork

Labels
3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@murphyatwork @wyb @gengjun-git