Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Add enable_active_materialized_view_schema_strict_check config to decide whether to check schema strictlly in activing mv #50869

Merged

Conversation

LiShuMing
Copy link
Contributor

@LiShuMing LiShuMing commented Sep 9, 2024

Why I'm doing:

What I'm doing:

  • Add enable_active_materialized_view_schema_strict_check config to decide whether to check schema strictlly in activing mv

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@LiShuMing LiShuMing requested a review from a team as a code owner September 9, 2024 11:56
@github-actions github-actions bot added the 3.3 label Sep 9, 2024
@LiShuMing LiShuMing force-pushed the fix/main/fix_mv_active_strict_check branch from 550a3c5 to a6c55a7 Compare September 9, 2024 12:04
@LiShuMing
Copy link
Contributor Author

@mergify rebase

Copy link
Contributor

mergify bot commented Sep 14, 2024

rebase

✅ Branch has been successfully rebased

@LiShuMing LiShuMing force-pushed the fix/main/fix_mv_active_strict_check branch from 438415f to 90270dc Compare September 14, 2024 08:19
@LiShuMing
Copy link
Contributor Author

@mergify rebase

…ide whether to check schema strictlly in activing mv

Signed-off-by: shuming.li <[email protected]>
Signed-off-by: shuming.li <[email protected]>
@LiShuMing LiShuMing force-pushed the fix/main/fix_mv_active_strict_check branch from 90270dc to 0ac20b4 Compare September 17, 2024 13:23
Copy link
Contributor

mergify bot commented Sep 17, 2024

rebase

✅ Branch has been successfully rebased

Copy link

sonarcloud bot commented Sep 17, 2024

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 13 / 14 (92.86%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/alter/AlterJobMgr.java 10 11 90.91% [296]
🔵 com/starrocks/scheduler/PartitionBasedMvRefreshProcessor.java 2 2 100.00% []
🔵 com/starrocks/common/Config.java 1 1 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@LiShuMing LiShuMing merged commit d4add5c into StarRocks:main Sep 18, 2024
46 checks passed
@LiShuMing LiShuMing deleted the fix/main/fix_mv_active_strict_check branch September 18, 2024 11:55
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Sep 18, 2024
Copy link
Contributor

mergify bot commented Sep 18, 2024

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 18, 2024
…ig to decide whether to check schema strictlly in activing mv (#50869)

Signed-off-by: shuming.li <[email protected]>
(cherry picked from commit d4add5c)
wanpengfei-git pushed a commit that referenced this pull request Sep 18, 2024
…ig to decide whether to check schema strictlly in activing mv (backport #50869) (#51117)

Co-authored-by: shuming.li <[email protected]>
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
…ig to decide whether to check schema strictlly in activing mv (StarRocks#50869)

Signed-off-by: shuming.li <[email protected]>
Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants