Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix the stack overflow of array_distinct #51017

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

trueeyu
Copy link
Contributor

@trueeyu trueeyu commented Sep 13, 2024

Why I'm doing:

*** Aborted at 1726191146 (unix time) try "date -d @1726191146" if you are using GNU date ***
PC: @          0x99a52e4 starrocks::ArrayFunctions::array_distinct_any_type(starrocks::FunctionContext*, std::vector<std::shared_ptr<starrocks::Column>, std::allocator<std::shared_ptr<starrocks::Column> > > const&)
*** SIGSEGV (@0x7f972945cb28) received by PID 3508434 (TID 0x7f9729c5c640) from PID 692439848; stack trace: ***
    @     0x7f98781e3ee8 (/usr/lib/x86_64-linux-gnu/libc.so.6+0x99ee7)
    @          0xcf22069 google::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*)
    @     0x7f987818c520 (/usr/lib/x86_64-linux-gnu/libc.so.6+0x4251f)
    @          0x99a52e4 starrocks::ArrayFunctions::array_distinct_any_type(starrocks::FunctionContext*, std::vector<std::shared_ptr<starrocks::Column>, std::al
locator<std::shared_ptr<starrocks::Column> > > const&)
    @          0x81461e2 starrocks::VectorizedFunctionCallExpr::evaluate_checked(starrocks::ExprContext*, starrocks::Chunk*)
    @          0x5a40203 starrocks::ExprContext::evaluate(starrocks::Expr*, starrocks::Chunk*, unsigned char*)
    @          0x8145f85 starrocks::VectorizedFunctionCallExpr::evaluate_checked(starrocks::ExprContext*, starrocks::Chunk*)
    @          0x5a40203 starrocks::ExprContext::evaluate(starrocks::Expr*, starrocks::Chunk*, unsigned char*)
    @          0x5a40712 starrocks::ExprContext::evaluate(starrocks::Chunk*, unsigned char*)
    @          0x7d914fc starrocks::pipeline::ProjectOperator::push_chunk(starrocks::RuntimeState*, std::shared_ptr<starrocks::Chunk> const&)
    @          0x5a8f0e3 starrocks::pipeline::PipelineDriver::process(starrocks::RuntimeState*, int)
    @          0x5b1e370 starrocks::pipeline::GlobalDriverExecutor::_worker_thread()
    @          0x9072432 starrocks::ThreadPool::dispatch_thread()
    @          0x906a6f9 starrocks::Thread::supervise_thread(void*)
    @     0x7f98781deac3 (/usr/lib/x86_64-linux-gnu/libc.so.6+0x94ac2)
    @     0x7f9878270850 (/usr/lib/x86_64-linux-gnu/libc.so.6+0x12684f)

What I'm doing:

Array will allocate memory on stack, If there are too many elements in array, it will cause stack overflow, so here we will use std::vector instead.

Current implementation will uses a lot of memory and needs to be optimized later.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@trueeyu
Copy link
Contributor Author

trueeyu commented Sep 18, 2024

@Mergifyio rebase main

Copy link
Contributor

mergify bot commented Sep 18, 2024

rebase main

✅ Branch has been successfully rebased

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 2 / 2 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exprs/array_functions.cpp 2 2 100.00% []

@trueeyu trueeyu merged commit 645b6b3 into StarRocks:main Sep 18, 2024
40 checks passed
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Sep 18, 2024
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Sep 18, 2024
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Sep 18, 2024
Copy link
Contributor

mergify bot commented Sep 18, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Sep 18, 2024

backport branch-3.2

✅ Backports have been created

Copy link
Contributor

mergify bot commented Sep 18, 2024

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 18, 2024
mergify bot pushed a commit that referenced this pull request Sep 18, 2024
mergify bot pushed a commit that referenced this pull request Sep 18, 2024
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants