Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix partition ttl loss after FE restart #51028

Merged
merged 1 commit into from
Sep 20, 2024
Merged

[BugFix] Fix partition ttl loss after FE restart #51028

merged 1 commit into from
Sep 20, 2024

Conversation

meegoo
Copy link
Contributor

@meegoo meegoo commented Sep 13, 2024 •
edited
Loading

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@meegoo meegoo requested a review from a team as a code owner September 13, 2024 13:20
@mergify mergify bot assigned meegoo Sep 13, 2024
@meegoo meegoo force-pushed the fix_partition_ttl branch 2 times, most recently from f9c64fc to f6ae9a5 Compare September 13, 2024 13:50
@meegoo meegoo enabled auto-merge (squash) September 14, 2024 02:25
@meegoo
Copy link
Contributor Author

meegoo commented Sep 20, 2024

@mergify rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 20, 2024

rebase

✅ Branch has been successfully rebased

@meegoo meegoo enabled auto-merge (squash) September 20, 2024 02:55
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 4 / 4 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/catalog/TableProperty.java 4 4 100.00% []

@meegoo meegoo merged commit 99b2440 into StarRocks:main Sep 20, 2024
40 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions github-actions bot removed the 3.3 label Sep 20, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Sep 20, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Sep 20, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 20, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 20, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 20, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 20, 2024
@meegoo @mergify
[BugFix] Fix partition ttl loss after FE restart (#51028)
6d062e0 
Signed-off-by: meegoo <[email protected]>
(cherry picked from commit 99b2440)
@mergify mergify bot mentioned this pull request Sep 20, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Sep 20, 2024
@meegoo @mergify
[BugFix] Fix partition ttl loss after FE restart (#51028)
2a984ac 
Signed-off-by: meegoo <[email protected]>
(cherry picked from commit 99b2440)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/catalog/TableProperty.java
@mergify mergify bot mentioned this pull request Sep 20, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Sep 20, 2024
@meegoo @mergify
[BugFix] Fix partition ttl loss after FE restart (#51028)
7b7d3a3 
Signed-off-by: meegoo <[email protected]>
(cherry picked from commit 99b2440)
@mergify mergify bot mentioned this pull request Sep 20, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Sep 20, 2024
@mergify @meegoo
[BugFix] Fix partition ttl loss after FE restart (backport #51028) (#…
92f91df 
…51192)

Co-authored-by: meegoo <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Sep 20, 2024
@mergify @meegoo
[BugFix] Fix partition ttl loss after FE restart (backport #51028) (#…
c715428 
…51194)

Co-authored-by: meegoo <[email protected]>
meegoo added a commit that referenced this pull request Sep 20, 2024
@mergify @meegoo
[BugFix] Fix partition ttl loss after FE restart (backport #51028) (#…
24d954c 
…51193)

Signed-off-by: meegoo <[email protected]>
Co-authored-by: meegoo <[email protected]>
@rohitrs1983 rohitrs1983 mentioned this pull request Oct 20, 2024
Open
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
@meegoo @renzhimin7
[BugFix] Fix partition ttl loss after FE restart (StarRocks#51028)
06e1ae7 
Signed-off-by: meegoo <[email protected]>
Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murphyatwork murphyatwork murphyatwork approved these changes

@gengjun-git gengjun-git gengjun-git approved these changes

Assignees

@meegoo meegoo

Labels
3.1-merged 3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meegoo @gengjun-git @murphyatwork