Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Support recovery FE metadata from meta dir #51040

Merged
merged 3 commits into from
Sep 29, 2024
Merged

[Enhancement] Support recovery FE metadata from meta dir #51040

merged 3 commits into from
Sep 29, 2024

Conversation

gengjun-git
Copy link
Contributor

@gengjun-git gengjun-git commented Sep 14, 2024 •
edited
Loading

Why I'm doing:

With this patch, it is possible to recover FE metadata if all machines are unavailable but the meta directory still exists.

  1. Start a FE node with the backup meta using config bdbje_reset_election_group = true in fe.conf.
  2. If the node is started, there will be a frontend in the cluster, and the IP address is the IP address of the new host.
  3. Check metadata.
  4. If everything is ok, remove the config bdbje_reset_election_group = true from fe.conf, and restart the node.
  5. Through the above steps, the cluster has been recovered and has only one follower node.

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@gengjun-git gengjun-git requested a review from a team as a code owner September 14, 2024 07:49
@wanpengfei-git wanpengfei-git requested a review from a team September 14, 2024 07:50
@github-actions github-actions bot added the 3.3 label Sep 14, 2024
@gengjun-git gengjun-git mentioned this pull request Sep 14, 2024
Closed
24 tasks
@gengjun-git
Copy link
Contributor Author

@Mergifyio rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 19, 2024

rebase

✅ Branch has been successfully rebased

nshangyiming
nshangyiming previously approved these changes Sep 25, 2024
View reviewed changes
@gengjun-git
fix
96a12a1 
Signed-off-by: gengjun-git <[email protected]>
@gengjun-git
fix
d195569 
Signed-off-by: gengjun-git <[email protected]>
@gengjun-git
fix
6633b11 
Signed-off-by: gengjun-git <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 23 / 24 (95.83%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/server/GlobalStateMgr.java 1 2 50.00% [1261]
🔵 com/starrocks/journal/bdbje/BDBEnvironment.java 2 2 100.00% []
🔵 com/starrocks/common/Config.java 1 1 100.00% []
🔵 com/starrocks/server/NodeMgr.java 14 14 100.00% []
🔵 com/starrocks/persist/EditLog.java 5 5 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@gengjun-git gengjun-git enabled auto-merge (squash) September 29, 2024 02:11
@gengjun-git gengjun-git merged commit 437544d into StarRocks:main Sep 29, 2024
47 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Sep 29, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 29, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 29, 2024
@gengjun-git @mergify
[Enhancement] Support recovery FE metadata from meta dir (#51040)
5673160 
## Why I'm doing:
With this patch, it is possible to recover FE metadata if all machines are unavailable but the meta directory still exists.
1. Start a FE node with the backup meta using config `bdbje_reset_election_group = true` in fe.conf.
2. If the node is started, there will be a frontend in the cluster, and the IP address is the IP address of the new host.
3. Check metadata.
4. If everything is ok, remove the config `bdbje_reset_election_group = true` from fe.conf, and restart the node.
5. Through the above steps, the cluster has been recovered and has only one follower node.

Signed-off-by: gengjun-git <[email protected]>
(cherry picked from commit 437544d)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/persist/EditLog.java
#	fe/fe-core/src/main/java/com/starrocks/persist/OperationType.java
#	fe/fe-core/src/main/java/com/starrocks/system/Frontend.java
@mergify mergify bot mentioned this pull request Sep 29, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Oct 8, 2024
@mergify @gengjun-git
[Enhancement] Support recovery FE metadata from meta dir (backport #5…
8a6e55f 
…1040) (#51525)

Signed-off-by: gengjun-git <[email protected]>
Co-authored-by: gengjun-git <[email protected]>
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
@gengjun-git @renzhimin7
[Enhancement] Support recovery FE metadata from meta dir (StarRocks#5…
1f1d458 
…1040)

## Why I'm doing:
With this patch, it is possible to recover FE metadata if all machines are unavailable but the meta directory still exists.
1. Start a FE node with the backup meta using config `bdbje_reset_election_group = true` in fe.conf.
2. If the node is started, there will be a frontend in the cluster, and the IP address is the IP address of the new host.
3. Check metadata.
4. If everything is ok, remove the config `bdbje_reset_election_group = true` from fe.conf, and restart the node.
5. Through the above steps, the cluster has been recovered and has only one follower node.

Signed-off-by: gengjun-git <[email protected]>
Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nshangyiming nshangyiming nshangyiming approved these changes

@Youngwb Youngwb Youngwb approved these changes

Assignees

@gengjun-git gengjun-git

Labels
3.3-merged META-REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gengjun-git @Youngwb @nshangyiming @wanpengfei-git