Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix UDTF wrong result when miss multibyte UTF-8 #51232

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

stdpain
Copy link
Contributor

@stdpain stdpain commented Sep 20, 2024

Why I'm doing:

introduced by #50615

mysql> select * from TABLE(udtfstring("中文"))
    -> ;
+------------+
| udtfstring |
+------------+
|            |
|            |
+------------+
2 rows in set (0.10 sec)

expected:

mysql> select * from TABLE(udtfstring("中文测试"));
+--------------+
| udtfstring   |
+--------------+
| 中文测试     |
| 中文测试     |
+--------------+

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

@stdpain stdpain merged commit 266bfc8 into StarRocks:main Sep 20, 2024
57 of 58 checks passed
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Sep 20, 2024
Copy link

@Mergifyio backport branch-3.2

Copy link

@Mergifyio backport branch-3.1

Copy link

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Sep 20, 2024
Copy link
Contributor

mergify bot commented Sep 20, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Sep 20, 2024

backport branch-3.2

✅ Backports have been created

Copy link
Contributor

mergify bot commented Sep 20, 2024

backport branch-3.1

✅ Backports have been created

Copy link
Contributor

mergify bot commented Sep 20, 2024

backport branch-3.0

✅ Backports have been created

Copy link

[BE Incremental Coverage Report]

pass : 4 / 4 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/udf/java/java_udf.cpp 4 4 100.00% []

mergify bot pushed a commit that referenced this pull request Sep 20, 2024
mergify bot pushed a commit that referenced this pull request Sep 20, 2024
mergify bot pushed a commit that referenced this pull request Sep 20, 2024
mergify bot pushed a commit that referenced this pull request Sep 20, 2024
Signed-off-by: stdpain <[email protected]>
(cherry picked from commit 266bfc8)

# Conflicts:
#	test/sql/test_udf/R/test_jvm_udf
#	test/sql/test_udf/T/test_jvm_udf
@stdpain
Copy link
Contributor Author

stdpain commented Sep 26, 2024

https://github.com/Mergifyio backport branch-3.3.4

Copy link
Contributor

mergify bot commented Sep 26, 2024

backport branch-3.3.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 26, 2024
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants