Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] refactor array_map's implementation #51244

Merged
merged 17 commits into from
Oct 1, 2024
Merged

[Enhancement] refactor array_map's implementation #51244

merged 17 commits into from
Oct 1, 2024

Conversation

silverbullet233
Copy link
Contributor

@silverbullet233 silverbullet233 commented Sep 21, 2024 •
edited
Loading

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@silverbullet233 silverbullet233 requested a review from a team as a code owner September 21, 2024 11:30
@silverbullet233 silverbullet233 changed the title [WIP] refactor array_Map [WIP] refactor array_map Sep 21, 2024
@silverbullet233 silverbullet233 changed the title [WIP] refactor array_map [Enhancement] refactor array_map's implementation Sep 23, 2024
@silverbullet233 silverbullet233 force-pushed the refactor_array_map branch 2 times, most recently from c9e8a1a to 4d92ff8 Compare September 26, 2024 06:58
trueeyu
trueeyu previously approved these changes Sep 26, 2024
View reviewed changes
trueeyu
trueeyu previously approved these changes Sep 26, 2024
View reviewed changes
LiShuMing
LiShuMing previously approved these changes Sep 27, 2024
View reviewed changes
satanson
satanson previously approved these changes Sep 27, 2024
View reviewed changes
be/src/column/array_column.cpp Show resolved Hide resolved
@silverbullet233
stash
2b154d9 
Signed-off-by: silverbullet233 <[email protected]>
@silverbullet233
extract common expr in array_map
9d80130 
Signed-off-by: silverbullet233 <[email protected]>
@silverbullet233
stash
9e1b4b4 
Signed-off-by: silverbullet233 <[email protected]>
@silverbullet233
stash: pass common test
d38b661 
Signed-off-by: silverbullet233 <[email protected]>
@silverbullet233
stash
ac6eae7 
Signed-off-by: silverbullet233 <[email protected]>
@silverbullet233
remove unused code
3a19f68 
Signed-off-by: silverbullet233 <[email protected]>
@silverbullet233
remove unused code
41d632e 
Signed-off-by: silverbullet233 <[email protected]>
@silverbullet233
fix
bbcb4c6 
Signed-off-by: silverbullet233 <[email protected]>
@silverbullet233
fix
07a5dc6 
Signed-off-by: silverbullet233 <[email protected]>
@silverbullet233
fix
33424ea 
Signed-off-by: silverbullet233 <[email protected]>
@silverbullet233
fix test
54e7527 
Signed-off-by: silverbullet233 <[email protected]>
@silverbullet233
fix ut
cabbe0f 
Signed-off-by: silverbullet233 <[email protected]>
@silverbullet233
fix format
7f5a479 
Signed-off-by: silverbullet233 <[email protected]>
@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 323 / 354 (91.24%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/column/nullable_column.h 0 1 00.00% [85]
🔵 be/src/column/const_column.h 0 1 00.00% [52]
🔵 be/src/column/array_column.h 0 1 00.00% [148]
🔵 be/src/exprs/lambda_function.cpp 77 86 89.53% [228, 229, 230, 231, 232, 233, 235, 236, 237]
🔵 be/src/exprs/array_map_expr.cpp 186 204 91.18% [87, 174, 214, 215, 227, 267, 329, 330, 331, 363, 364, 365, 366, 367, 368, 370, 371, 372]
🔵 be/src/column/array_column.cpp 44 45 97.78% [688]
🔵 be/src/exprs/literal.h 1 1 100.00% []
🔵 be/src/exprs/map_apply_expr.cpp 2 2 100.00% []
🔵 be/src/column/chunk.cpp 1 1 100.00% []
🔵 be/src/exprs/lambda_function.h 9 9 100.00% []
🔵 be/src/column/column.cpp 1 1 100.00% []
🔵 be/src/exprs/expr.h 2 2 100.00% []

@silverbullet233 silverbullet233 merged commit e9eedcd into StarRocks:main Oct 1, 2024
44 checks passed
@silverbullet233 silverbullet233 deleted the refactor_array_map branch October 1, 2024 16:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Oct 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Oct 1, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 1, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 1, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 1, 2024
@silverbullet233 @mergify
[Enhancement] refactor array_map's implementation (#51244)
c76f3bb 
Signed-off-by: silverbullet233 <[email protected]>
(cherry picked from commit e9eedcd)

# Conflicts:
#	be/src/column/column.cpp
#	be/src/exprs/literal.h
mergify bot pushed a commit that referenced this pull request Oct 1, 2024
@silverbullet233 @mergify
[Enhancement] refactor array_map's implementation (#51244)
56fefe1 
Signed-off-by: silverbullet233 <[email protected]>
(cherry picked from commit e9eedcd)

# Conflicts:
#	be/src/column/column.cpp
#	be/src/exprs/expr.h
#	be/src/exprs/literal.h
This was referenced Oct 1, 2024
Merged
Merged
silverbullet233 added a commit that referenced this pull request Oct 2, 2024
@mergify @silverbullet233
[Enhancement] refactor array_map's implementation (backport #51244) (#…
b2cb16e 
…51574)

Signed-off-by: silverbullet233 <[email protected]>
Co-authored-by: eyes_on_me <[email protected]>
Co-authored-by: silverbullet233 <[email protected]>
@silverbullet233 silverbullet233 mentioned this pull request Oct 8, 2024
Merged
24 tasks
silverbullet233 added a commit that referenced this pull request Oct 8, 2024
@mergify @silverbullet233
[Enhancement] refactor array_map's implementation (backport #51244) (#…
ec8ae44 
…51575)

Signed-off-by: silverbullet233 <[email protected]>
Co-authored-by: eyes_on_me <[email protected]>
Co-authored-by: silverbullet233 <[email protected]>
This was referenced Oct 8, 2024
Merged
Merged
@silverbullet233 silverbullet233 mentioned this pull request Oct 14, 2024
Merged
24 tasks
This was referenced Oct 14, 2024
Merged
Merged
Merged
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
@silverbullet233 @renzhimin7
[Enhancement] refactor array_map's implementation (StarRocks#51244)
7dc5473 
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaoyli chaoyli chaoyli approved these changes

@trueeyu trueeyu trueeyu approved these changes

@LiShuMing LiShuMing LiShuMing left review comments

@satanson satanson satanson left review comments

Assignees

@silverbullet233 silverbullet233

Labels
3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@silverbullet233 @satanson @LiShuMing @trueeyu @chaoyli