Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] handle const column in array_filter #51363

Merged
merged 2 commits into from
Sep 27, 2024
Merged

[Enhancement] handle const column in array_filter #51363

merged 2 commits into from
Sep 27, 2024
+253 −57

Conversation

silverbullet233
Copy link
Contributor

@silverbullet233 silverbullet233 commented Sep 25, 2024 •
edited
Loading

Why I'm doing:

What I'm doing:

The array_filter function needs to unpack all const columns before evaluation. In fact, we can do some special handling on them.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@silverbullet233 silverbullet233 requested a review from a team as a code owner September 25, 2024 02:52
@silverbullet233
optimize array_filter
17f0600 
Signed-off-by: silverbullet233 <[email protected]>
@silverbullet233
fix format
2fdda97 
Signed-off-by: silverbullet233 <[email protected]>
@github-actions github-actions bot added the 3.3 label Sep 25, 2024
@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 82 / 82 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exprs/array_functions.tpp 82 82 100.00% []

@silverbullet233 silverbullet233 enabled auto-merge (squash) September 26, 2024 07:04
@silverbullet233 silverbullet233 merged commit 0c35297 into StarRocks:main Sep 27, 2024
67 of 71 checks passed
@silverbullet233 silverbullet233 deleted the opt_array_filter branch September 27, 2024 02:09
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Sep 27, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 27, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 27, 2024
@silverbullet233 @mergify
[Enhancement] handle const column in array_filter (#51363)
45e6ccd 
Signed-off-by: silverbullet233 <[email protected]>
(cherry picked from commit 0c35297)
@mergify mergify bot mentioned this pull request Sep 27, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Sep 27, 2024
@mergify @silverbullet233
[Enhancement] handle const column in array_filter (backport #51363) (#…
a512535 
…51474)

Co-authored-by: eyes_on_me <[email protected]>
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
@silverbullet233 @renzhimin7
[Enhancement] handle const column in array_filter (StarRocks#51363)
4e70e0d 
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: zhiminr.ren <[email protected]>
@silverbullet233
Copy link
Contributor Author

@mergify backport branch-3.2

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 15, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 15, 2024
@silverbullet233 @mergify
[Enhancement] handle const column in array_filter (#51363)
4b4c6b5 
Signed-off-by: silverbullet233 <[email protected]>
(cherry picked from commit 0c35297)

# Conflicts:
#	be/src/exprs/array_functions.tpp
@mergify mergify bot mentioned this pull request Nov 15, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Nov 15, 2024
@mergify @silverbullet233
[Enhancement] handle const column in array_filter (backport #51363) (#…
1d7cef7 
…52938)

Signed-off-by: silverbullet233 <[email protected]>
Co-authored-by: eyes_on_me <[email protected]>
Co-authored-by: silverbullet233 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueeyu trueeyu trueeyu approved these changes

@Seaven Seaven Seaven approved these changes

Assignees

@silverbullet233 silverbullet233

Labels
3.2-merged 3.2 3.3-merged 3.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silverbullet233 @Seaven @trueeyu