Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix unexpected Hint when UPDATE Stmt has CTE #51458

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

stdpain
Copy link
Contributor

@stdpain stdpain commented Sep 26, 2024

Why I'm doing:

reproduce 1

select percentile_approx(c0, cast(null as double))  from t0;

reproduce 2:

CREATE TABLE `pk1` (
  `c0` int(11) COMMENT "",
  `dt` int(11) COMMENT ""
) ENGINE=OLAP
PRIMARY KEY(`c0`)
COMMENT "OLAP"
DISTRIBUTED BY HASH(`c0`) BUCKETS 1
PROPERTIES (
"replication_num" = "1"
);
insert into pk1 values (1,1);

with cte as (select* from pk1)
update /*+ set_user_variable(@a = (select 2)) */ pk1 set dt = @a where c0 = 1;
select * from pk1;

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Seaven
Seaven previously approved these changes Sep 26, 2024
satanson
satanson previously approved these changes Sep 26, 2024
Signed-off-by: stdpain <[email protected]>
Signed-off-by: stdpain <[email protected]>
Copy link

sonarcloud bot commented Sep 27, 2024

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 3 / 3 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exprs/agg/percentile_approx.h 3 3 100.00% []

@kangkaisen kangkaisen merged commit ecd7cd9 into StarRocks:main Oct 2, 2024
48 of 49 checks passed
Copy link

github-actions bot commented Oct 2, 2024

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Oct 2, 2024
Copy link

github-actions bot commented Oct 2, 2024

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Oct 2, 2024
Copy link

github-actions bot commented Oct 2, 2024

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Oct 2, 2024
Copy link

github-actions bot commented Oct 2, 2024

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Oct 2, 2024
Copy link
Contributor

mergify bot commented Oct 2, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Oct 2, 2024

backport branch-3.2

✅ Backports have been created

Copy link
Contributor

mergify bot commented Oct 2, 2024

backport branch-3.1

✅ Backports have been created

Copy link
Contributor

mergify bot commented Oct 2, 2024

backport branch-3.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 2, 2024
mergify bot pushed a commit that referenced this pull request Oct 2, 2024
mergify bot pushed a commit that referenced this pull request Oct 2, 2024
Signed-off-by: stdpain <[email protected]>
(cherry picked from commit ecd7cd9)

# Conflicts:
#	test/sql/test_user_variables/R/test_user_variable
#	test/sql/test_user_variables/T/test_user_variable
mergify bot pushed a commit that referenced this pull request Oct 2, 2024
Signed-off-by: stdpain <[email protected]>
(cherry picked from commit ecd7cd9)

# Conflicts:
#	test/sql/test_user_variables/R/test_user_variable
#	test/sql/test_user_variables/T/test_user_variable
wanpengfei-git pushed a commit that referenced this pull request Oct 2, 2024
wanpengfei-git pushed a commit that referenced this pull request Oct 2, 2024
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants