[BugFix] Fix UnionAll cannot process order by expression #51647

stdpain · 2024-10-09T03:15:17Z

Why I'm doing:

select 1 union all select 1 order by null;

java.lang.ClassCastException: class com.starrocks.sql.optimizer.operator.scalar.ConstantOperator cannot be cast to class com.starrocks.sql.optimizer.operator.scalar.ColumnRefOperator (com.starrocks.sql.optimizer.operator.scalar.ConstantOperator and com.starrocks.sql.optimizer.operator.scalar.ColumnRefOperator are in unnamed module of loader 'app')

What I'm doing:

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
This is a backport pr

Bugfix cherry-pick branch check:

Signed-off-by: stdpain <[email protected]>

fe/fe-core/src/main/java/com/starrocks/sql/optimizer/transformer/RelationTransformer.java

Signed-off-by: stdpain <[email protected]>

sonarcloud · 2024-10-09T11:25:39Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2024-10-09T12:54:31Z

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-10-09T12:55:08Z

[FE Incremental Coverage Report]

✅ pass : 33 / 39 (84.62%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/sql/optimizer/transformer/RelationTransformer.java	33	39	84.62%	[442, 443, 444, 445, 447, 455]

github-actions · 2024-10-09T12:55:12Z

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-10-10T02:06:09Z

@Mergifyio backport branch-3.3

github-actions · 2024-10-10T02:06:10Z

@Mergifyio backport branch-3.2

github-actions · 2024-10-10T02:06:12Z

@Mergifyio backport branch-3.1

github-actions · 2024-10-10T02:06:13Z

@Mergifyio backport branch-3.0

mergify · 2024-10-10T02:06:14Z

backport branch-3.3

✅ Backports have been created

#51689 [BugFix] Fix UnionAll cannot process order by expression (backport #51647) has been created for branch branch-3.3

mergify · 2024-10-10T02:06:15Z

backport branch-3.2

✅ Backports have been created

#51690 [BugFix] Fix UnionAll cannot process order by expression (backport #51647) has been created for branch branch-3.2 but encountered conflicts

mergify · 2024-10-10T02:06:19Z

backport branch-3.1

✅ Backports have been created

#51691 [BugFix] Fix UnionAll cannot process order by expression (backport #51647) has been created for branch branch-3.1

mergify · 2024-10-10T02:06:20Z

backport branch-3.0

✅ Backports have been created

#51692 [BugFix] Fix UnionAll cannot process order by expression (backport #51647) has been created for branch branch-3.0

Signed-off-by: stdpain <[email protected]> (cherry picked from commit bf39677)

Signed-off-by: stdpain <[email protected]> (cherry picked from commit bf39677) # Conflicts: # fe/fe-core/src/test/java/com/starrocks/sql/plan/SetTest.java

Signed-off-by: stdpain <[email protected]> (cherry picked from commit bf39677)

…1647) (#51689) Co-authored-by: stdpain <[email protected]>

…1647) Signed-off-by: stdpain <[email protected]> (cherry picked from commit bf39677) Signed-off-by: stdpain <[email protected]>

Signed-off-by: stdpain <[email protected]> (cherry picked from commit bf39677)

…1647) (#51751) Signed-off-by: stdpain <[email protected]>

…1647) Signed-off-by: stdpain <[email protected]>

…1647) Signed-off-by: stdpain <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>

[BugFix] Fix UnionAll cannot process order by expression

708c56c

Signed-off-by: stdpain <[email protected]>

stdpain requested a review from a team as a code owner October 9, 2024 03:15

github-actions bot added 3.3 3.2 3.1 3.0 labels Oct 9, 2024

mergify bot assigned stdpain Oct 9, 2024

Seaven reviewed Oct 9, 2024

View reviewed changes

fe/fe-core/src/main/java/com/starrocks/sql/optimizer/transformer/RelationTransformer.java Show resolved Hide resolved

Seaven reviewed Oct 9, 2024

View reviewed changes

fe/fe-core/src/main/java/com/starrocks/sql/optimizer/transformer/RelationTransformer.java Outdated Show resolved Hide resolved

LiShuMing previously approved these changes Oct 9, 2024

View reviewed changes

fix not has order by

9fee5bb

Signed-off-by: stdpain <[email protected]>

stdpain dismissed LiShuMing’s stale review via 9fee5bb October 9, 2024 06:11

LiShuMing previously approved these changes Oct 9, 2024

View reviewed changes

fix comments

01cec7d

Signed-off-by: stdpain <[email protected]>

stdpain dismissed LiShuMing’s stale review via 01cec7d October 9, 2024 11:17

Seaven approved these changes Oct 9, 2024

View reviewed changes

LiShuMing approved these changes Oct 10, 2024

View reviewed changes

stdpain merged commit bf39677 into StarRocks:main Oct 10, 2024
51 checks passed

github-actions bot removed the 3.3 label Oct 10, 2024

github-actions bot removed the 3.2 label Oct 10, 2024

github-actions bot removed the 3.1 label Oct 10, 2024

github-actions bot removed the 3.0 label Oct 10, 2024

mergify bot pushed a commit that referenced this pull request Oct 10, 2024

[BugFix] Fix UnionAll cannot process order by expression (#51647)

85d6f30

Signed-off-by: stdpain <[email protected]> (cherry picked from commit bf39677)

mergify bot mentioned this pull request Oct 10, 2024

[BugFix] Fix UnionAll cannot process order by expression (backport #51647) #51689

Merged

42 tasks

mergify bot pushed a commit that referenced this pull request Oct 10, 2024

[BugFix] Fix UnionAll cannot process order by expression (#51647)

de6b8f1

Signed-off-by: stdpain <[email protected]> (cherry picked from commit bf39677)

This was referenced Oct 10, 2024

[BugFix] Fix UnionAll cannot process order by expression (backport #51647) #51690

Closed

[BugFix] Fix UnionAll cannot process order by expression (backport #51647) #51691

Open

mergify bot pushed a commit that referenced this pull request Oct 10, 2024

[BugFix] Fix UnionAll cannot process order by expression (#51647)

84b131a

Signed-off-by: stdpain <[email protected]> (cherry picked from commit bf39677)

mergify bot mentioned this pull request Oct 10, 2024

[BugFix] Fix UnionAll cannot process order by expression (backport #51647) #51692

Open

42 tasks

wanpengfei-git pushed a commit that referenced this pull request Oct 10, 2024

[BugFix] Fix UnionAll cannot process order by expression (backport #5…

370252c

…1647) (#51689) Co-authored-by: stdpain <[email protected]>

github-actions bot added the 3.3-merged label Oct 10, 2024

stdpain added a commit that referenced this pull request Oct 11, 2024

[BugFix] Fix UnionAll cannot process order by expression (#51647)

5620aa6

Signed-off-by: stdpain <[email protected]> (cherry picked from commit bf39677)

kangkaisen pushed a commit that referenced this pull request Oct 11, 2024

[BugFix] Fix UnionAll cannot process order by expression (backport #5…

9017b14

…1647) (#51751) Signed-off-by: stdpain <[email protected]>

github-actions bot added the 3.2-merged label Oct 11, 2024

ZiheLiu pushed a commit to ZiheLiu/starrocks that referenced this pull request Oct 31, 2024

[BugFix] Fix UnionAll cannot process order by expression (StarRocks#5…

7304ea7

…1647) Signed-off-by: stdpain <[email protected]>

renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024

[BugFix] Fix UnionAll cannot process order by expression (StarRocks#5…

2b91642

…1647) Signed-off-by: stdpain <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BugFix] Fix UnionAll cannot process order by expression #51647

[BugFix] Fix UnionAll cannot process order by expression #51647

stdpain commented Oct 9, 2024

sonarcloud bot commented Oct 9, 2024

github-actions bot commented Oct 9, 2024

github-actions bot commented Oct 9, 2024

github-actions bot commented Oct 9, 2024

github-actions bot commented Oct 10, 2024

github-actions bot commented Oct 10, 2024

github-actions bot commented Oct 10, 2024

github-actions bot commented Oct 10, 2024

mergify bot commented Oct 10, 2024 •

edited

Loading

mergify bot commented Oct 10, 2024 •

edited

Loading

mergify bot commented Oct 10, 2024 •

edited

Loading

mergify bot commented Oct 10, 2024 •

edited

Loading

[BugFix] Fix UnionAll cannot process order by expression #51647

[BugFix] Fix UnionAll cannot process order by expression #51647

Conversation

stdpain commented Oct 9, 2024

Why I'm doing:

What I'm doing:

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

sonarcloud bot commented Oct 9, 2024

Quality Gate passed

github-actions bot commented Oct 9, 2024

[Java-Extensions Incremental Coverage Report]

github-actions bot commented Oct 9, 2024

[FE Incremental Coverage Report]

file detail

github-actions bot commented Oct 9, 2024

[BE Incremental Coverage Report]

github-actions bot commented Oct 10, 2024

github-actions bot commented Oct 10, 2024

github-actions bot commented Oct 10, 2024

github-actions bot commented Oct 10, 2024

mergify bot commented Oct 10, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Oct 10, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Oct 10, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Oct 10, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Oct 10, 2024 •

edited

Loading

mergify bot commented Oct 10, 2024 •

edited

Loading

mergify bot commented Oct 10, 2024 •

edited

Loading

mergify bot commented Oct 10, 2024 •

edited

Loading