Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] When the reserved keyword uses backquotes as input, deserialization causes parseSqlToExpr syntax error, which results in log edit failure. #51677

Merged
merged 7 commits into from
Oct 14, 2024
Merged

[BugFix] When the reserved keyword uses backquotes as input, deserialization causes parseSqlToExpr syntax error, which results in log edit failure. #51677

merged 7 commits into from
Oct 14, 2024

Conversation

zhangheihei
Copy link
Contributor

@zhangheihei zhangheihei commented Oct 9, 2024 •
edited
Loading

Why I'm doing:

There is a difference between that the pr and 51781.
Error scenario encountered with the create sql in version3.3:
1 create tablet succeeds
2 getEditLog().logCreateTable reported error
3 Restart FE, table is missing.
image

What I'm doing:

Fixes #51678

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@zhangheihei zhangheihei requested a review from a team as a code owner October 9, 2024 12:43
@zhangheihei zhangheihei requested a review from a team as a code owner October 9, 2024 17:20
@Seaven
Copy link
Contributor

Seaven commented Oct 10, 2024

fix test case plz, and you can add some UT

@kangkaisen
Copy link
Collaborator

Please add more UT.

@github-actions github-actions bot removed the 3.3 label Oct 11, 2024
@zhangheihei zhangheihei reopened this Oct 11, 2024
@zhangheihei zhangheihei changed the title [BugFix] When the reserved keyword uses backquotes as input, deserialization causes parseSqlToExpr syntax error, which results in a checkpoint failure. [BugFix] When the reserved keyword uses backquotes as input, deserialization causes parseSqlToExpr syntax error, which results in log edit failure. Oct 11, 2024
@zhangheihei zhangheihei requested review from a team as code owners October 11, 2024 17:15
@zhangheihei
[BugFix] When the reserved keyword uses backquotes as input, deserial…
751d31b 
…ization causes a parseSqlToExpr syntax error, which results in a checkpoint failure.

Signed-off-by: edwinhzhang <[email protected]>
@zhangheihei
fix ut
96b574c 
Signed-off-by: edwinhzhang <[email protected]>
@zhangheihei
add UT
260bf4f 
Signed-off-by: edwinhzhang <[email protected]>
@github-actions github-actions bot added 3.3 and removed 3.2 3.1 labels Oct 11, 2024
@zhangheihei
add UT
e758f77 
Signed-off-by: edwinhzhang <[email protected]>
@zhangheihei zhangheihei force-pushed the bugfix-back-quoted-identifier branch 2 times, most recently from f99dcb6 to 434308c Compare October 12, 2024 03:04
trueeyu
trueeyu previously approved these changes Oct 12, 2024
View reviewed changes
@zhangheihei
fix sql test
e4e6b23 
Signed-off-by: edwinhzhang <[email protected]>
@zhangheihei
Add toSql Semantics.
a0bf266 
Signed-off-by: edwinhzhang <[email protected]>
@zhangheihei zhangheihei force-pushed the bugfix-back-quoted-identifier branch 2 times, most recently from 9eb2856 to c210c7b Compare October 13, 2024 15:59
@zhangheihei
fix style
b199aaf 
Signed-off-by: edwinhzhang <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 13, 2024

Quality Gate Passed Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 18 / 18 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/ast/Identifier.java 4 4 100.00% []
🔵 com/starrocks/catalog/ColumnId.java 3 3 100.00% []
🔵 com/starrocks/analysis/SlotRef.java 8 8 100.00% []
🔵 com/starrocks/persist/ColumnIdExpr.java 2 2 100.00% []
🔵 com/starrocks/catalog/ExpressionRangePartitionInfo.java 1 1 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@wyb wyb merged commit fda1c95 into StarRocks:main Oct 14, 2024
56 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Oct 14, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 14, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 14, 2024
@zhangheihei @mergify
[BugFix] When the reserved keyword uses backquotes as input, deserial…
ecc0c8a 
…ization causes parseSqlToExpr syntax error, which results in log edit failure. (#51677)

Signed-off-by: edwinhzhang <[email protected]>
(cherry picked from commit fda1c95)
@mergify mergify bot mentioned this pull request Oct 14, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Oct 14, 2024
@mergify @zhangheihei
[BugFix] When the reserved keyword uses backquotes as input, deserial…
06d7999 
…ization causes parseSqlToExpr syntax error, which results in log edit failure. (backport #51677) (#51878)

Co-authored-by: zhanghe <[email protected]>
ZiheLiu pushed a commit to ZiheLiu/starrocks that referenced this pull request Oct 31, 2024
@zhangheihei @ZiheLiu
[BugFix] When the reserved keyword uses backquotes as input, deserial…
0e05147 
…ization causes parseSqlToExpr syntax error, which results in log edit failure. (StarRocks#51677)

Signed-off-by: edwinhzhang <[email protected]>
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
@zhangheihei @renzhimin7
[BugFix] When the reserved keyword uses backquotes as input, deserial…
4be5b31 
…ization causes parseSqlToExpr syntax error, which results in log edit failure. (StarRocks#51677)

Signed-off-by: edwinhzhang <[email protected]>
Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengjun-git gengjun-git gengjun-git approved these changes

@Seaven Seaven Seaven approved these changes

@wyb wyb wyb approved these changes

@trueeyu trueeyu Awaiting requested review from trueeyu

Assignees

@zhangheihei zhangheihei

Labels
3.3-merged behavior_changed
Projects
None yet
Milestone
No milestone
6 participants
@zhangheihei @Seaven @kangkaisen @wyb @trueeyu @gengjun-git