Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Support gc for cloud native persistent index files #51684

Merged
merged 2 commits into from
Oct 10, 2024
Merged

[Enhancement] Support gc for cloud native persistent index files #51684

merged 2 commits into from
Oct 10, 2024

Conversation

luohaha
Copy link
Contributor

@luohaha luohaha commented Oct 9, 2024

Why I'm doing:

In the current implementation, there are two scenarios where cloud native persistent index files cannot be reclaimed:

  1. Performing a full garbage collection on files using the meta tool.
  2. When executing a tablet drop.

What I'm doing:

Support gc for cloud native persistent index files in these two scenarios.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@luohaha luohaha requested a review from a team as a code owner October 9, 2024 22:48
@mergify mergify bot assigned luohaha Oct 9, 2024
@github-actions github-actions bot added the 3.3 label Oct 9, 2024
@luohaha
fix ut
e60421a 
Signed-off-by: luohaha <[email protected]>
@wyb wyb changed the title [Enhancement] support gc for cloud native persistent index files [Enhancement] Support gc for cloud native persistent index files Oct 10, 2024
@wyb wyb enabled auto-merge (squash) October 10, 2024 02:18
@luohaha luohaha requested a review from kevincai October 10, 2024 02:35
@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 12 / 12 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/lake/filenames.h 2 2 100.00% []
🔵 be/src/storage/lake/vacuum.cpp 10 10 100.00% []

@wyb wyb merged commit 8a8687e into StarRocks:main Oct 10, 2024
53 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Oct 10, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 10, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 10, 2024
@luohaha @mergify
[Enhancement] Support gc for cloud native persistent index files (#51684
3487630 
)

Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 8a8687e)
@mergify mergify bot mentioned this pull request Oct 10, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Oct 10, 2024
@mergify @luohaha
[Enhancement] Support gc for cloud native persistent index files (bac…
445391f 
…kport #51684) (#51698)

Co-authored-by: Yixin Luo <[email protected]>
ZiheLiu pushed a commit to ZiheLiu/starrocks that referenced this pull request Oct 31, 2024
@luohaha @ZiheLiu
[Enhancement] Support gc for cloud native persistent index files (Sta…
4a88e8e 
…rRocks#51684)

Signed-off-by: luohaha <[email protected]>
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
@luohaha @renzhimin7
[Enhancement] Support gc for cloud native persistent index files (Sta…
240f07f 
…rRocks#51684)

Signed-off-by: luohaha <[email protected]>
Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangguangyxg xiangguangyxg xiangguangyxg approved these changes

@wyb wyb wyb approved these changes

@kevincai kevincai kevincai approved these changes

Assignees

@luohaha luohaha

Labels
3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luohaha @kevincai @wyb @xiangguangyxg