Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Improve files() with wrong credentials error message #51697

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

wyb
Copy link
Contributor

@wyb wyb commented Oct 10, 2024

Why I'm doing:

mysql> select * from files(     "path" = "s3://xxx",     "format" = "csv",     "aws.s3.access_key" = "xxx",     "aws.s3.secret_key" = "yyy",     "aws.s3.region" = "us-west-2" );
ERROR 1064 (HY000): Access storage error. Error code: null. Error message: null.

What I'm doing:

mysql> select * from files(     "path" = "s3://xxx",     "format" = "csv",     "aws.s3.access_key" = "xxx",     "aws.s3.secret_key" = "yyy",     "aws.s3.region" = "us-west-2" );
ERROR 1064 (HY000): Access storage error. Error message: null (Service: S3, Status Code: 403, Request ID: K3CJ30H0FXXX, Extended Request ID: iSJrLAKZrEud8jyVET78KClqmpqH3n4t/JdcflMPQZ==)

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Copy link

sonarcloud bot commented Oct 10, 2024

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

fail : 4 / 6 (66.67%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/analyzer/StorageAccessException.java 4 6 66.67% [43, 46]

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@wanpengfei-git wanpengfei-git merged commit 930c97b into StarRocks:main Oct 10, 2024
53 of 54 checks passed
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Oct 10, 2024
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Oct 10, 2024
Copy link
Contributor

mergify bot commented Oct 10, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Oct 10, 2024

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 10, 2024
mergify bot pushed a commit that referenced this pull request Oct 10, 2024
wanpengfei-git pushed a commit that referenced this pull request Oct 10, 2024
wanpengfei-git pushed a commit that referenced this pull request Oct 10, 2024
LiShuMing pushed a commit to LiShuMing/starrocks that referenced this pull request Oct 11, 2024
ZiheLiu pushed a commit to ZiheLiu/starrocks that referenced this pull request Oct 31, 2024
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants