Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Make some system tables query from leader fe #51763

Merged
merged 1 commit into from
Oct 12, 2024
Merged

[Enhancement] Make some system tables query from leader fe #51763

merged 1 commit into from
Oct 12, 2024

Conversation

wyb
Copy link
Contributor

@wyb wyb commented Oct 11, 2024

Why I'm doing:

some metadata may be inaccurate in the follower fe, because they may be not persisted in leader fe,
such as routine load job state changed from NEED_SCHEDULE to RUNNING.

What I'm doing:

these system tables should query from leader fe.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@wyb wyb requested a review from a team as a code owner October 11, 2024 05:09
@mergify mergify bot assigned wyb Oct 11, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 28 / 30 (93.33%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/plan/PlanFragmentBuilder.java 3 5 60.00% [1650, 1651]
🔵 com/starrocks/catalog/system/information/TemporaryTablesTable.java 1 1 100.00% []
🔵 com/starrocks/catalog/system/sys/GrantsTo.java 2 2 100.00% []
🔵 com/starrocks/catalog/system/sys/RoleEdges.java 1 1 100.00% []
🔵 com/starrocks/catalog/system/information/BeDataCacheMetricsTable.java 1 1 100.00% []
🔵 com/starrocks/catalog/system/information/TablesSystemTable.java 1 1 100.00% []
🔵 com/starrocks/catalog/system/SystemTable.java 19 19 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@wyb wyb merged commit da80492 into StarRocks:main Oct 12, 2024
50 of 51 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Oct 12, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Oct 12, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 12, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 12, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 12, 2024
@wyb @mergify
[Enhancement] Make some system tables query from leader fe (#51763)
ffbe90b 
Signed-off-by: wyb <[email protected]>
(cherry picked from commit da80492)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/plan/PlanFragmentBuilder.java
@mergify mergify bot mentioned this pull request Oct 12, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Oct 12, 2024
@wyb @mergify
[Enhancement] Make some system tables query from leader fe (#51763)
9794135 
Signed-off-by: wyb <[email protected]>
(cherry picked from commit da80492)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/catalog/system/SystemTable.java
#	fe/fe-core/src/main/java/com/starrocks/catalog/system/information/BeDataCacheMetricsTable.java
#	fe/fe-core/src/main/java/com/starrocks/catalog/system/information/TaskRunsSystemTable.java
#	fe/fe-core/src/main/java/com/starrocks/catalog/system/information/TasksSystemTable.java
#	fe/fe-core/src/main/java/com/starrocks/catalog/system/information/TemporaryTablesTable.java
#	fe/fe-core/src/main/java/com/starrocks/sql/plan/PlanFragmentBuilder.java
@mergify mergify bot mentioned this pull request Oct 12, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Oct 12, 2024
@mergify @wyb
[Enhancement] Make some system tables query from leader fe (backport #…
3a181d8 
…51763) (#51822)

Co-authored-by: wyb <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Oct 12, 2024
@mergify @wyb
[Enhancement] Make some system tables query from leader fe (backport #…
a1a525c 
…51763) (#51823)

Co-authored-by: wyb <[email protected]>
ZiheLiu pushed a commit to ZiheLiu/starrocks that referenced this pull request Oct 31, 2024
@wyb @ZiheLiu
[Enhancement] Make some system tables query from leader fe (StarRocks…
febac8e 
…#51763)

Signed-off-by: wyb <[email protected]>
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
@wyb @renzhimin7
[Enhancement] Make some system tables query from leader fe (StarRocks…
37f8336 
…#51763)

Signed-off-by: wyb <[email protected]>
Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengjun-git gengjun-git gengjun-git approved these changes

@meegoo meegoo meegoo approved these changes

Assignees

@wyb wyb

Labels
3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wyb @meegoo @gengjun-git