[BugFix] Fix NullPointerException in getTabletsInHighLoadPath when select tablets to balance #51828

gengjun-git · 2024-10-12T03:06:59Z

Why I'm doing:

What I'm doing:

Fixes

2024-10-08 21:22:34.695+05:00 ERROR (tablet scheduler|68) [Daemon.run():109] daemon thread got exception. name: tablet scheduler
java.lang.NullPointerException: null
        at com.starrocks.clone.DiskAndTabletLoadReBalancer$BackendBalanceState.getTabletsInHighLoadPath(DiskAndTabletLoadReBalancer.java:2077) ~[starrocks-fe.jar:?]
        at com.starrocks.clone.DiskAndTabletLoadReBalancer.balanceClusterDisk(DiskAndTabletLoadReBalancer.java:530) ~[starrocks-fe.jar:?]
        at com.starrocks.clone.DiskAndTabletLoadReBalancer.selectAlternativeTabletsForCluster(DiskAndTabletLoadReBalancer.java:98) ~[starrocks-fe.jar:?]
        at com.starrocks.clone.Rebalancer.selectAlternativeTablets(Rebalancer.java:67) ~[starrocks-fe.jar:?]
        at com.starrocks.clone.TabletScheduler.selectTabletsForBalance(TabletScheduler.java:1557) ~[starrocks-fe.jar:?]
        at com.starrocks.clone.TabletScheduler.runAfterCatalogReady(TabletScheduler.java:457) ~[starrocks-fe.jar:?]
        at com.starrocks.common.util.FrontendDaemon.runOneCycle(FrontendDaemon.java:72) ~[starrocks-fe.jar:?]
        at com.starrocks.common.util.Daemon.run(Daemon.java:107) ~[starrocks-fe.jar:?]

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
This is a backport pr

Bugfix cherry-pick branch check:

gengjun-git · 2024-10-12T09:56:34Z

@Mergifyio rebase

Signed-off-by: gengjun-git <[email protected]>

mergify · 2024-10-12T09:57:06Z

rebase

✅ Branch has been successfully rebased

sonarcloud · 2024-10-12T10:04:26Z

Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2024-10-12T11:49:27Z

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-10-12T11:50:05Z

[FE Incremental Coverage Report]

❌ fail : 2 / 5 (40.00%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/clone/DiskAndTabletLoadReBalancer.java	2	5	40.00%	[2091, 2092, 2093]

github-actions · 2024-10-12T11:50:14Z

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-10-12T11:52:35Z

@Mergifyio backport branch-3.3

github-actions · 2024-10-12T11:52:36Z

@Mergifyio backport branch-3.2

github-actions · 2024-10-12T11:52:37Z

@Mergifyio backport branch-3.1

mergify · 2024-10-12T11:52:40Z

backport branch-3.3

✅ Backports have been created

#51849 [BugFix] Fix NullPointerException in getTabletsInHighLoadPath when select tablets to balance (backport #51828) has been created for branch branch-3.3

mergify · 2024-10-12T11:52:41Z

backport branch-3.2

✅ Backports have been created

#51850 [BugFix] Fix NullPointerException in getTabletsInHighLoadPath when select tablets to balance (backport #51828) has been created for branch branch-3.2

mergify · 2024-10-12T11:52:42Z

backport branch-3.1

✅ Backports have been created

#51851 [BugFix] Fix NullPointerException in getTabletsInHighLoadPath when select tablets to balance (backport #51828) has been created for branch branch-3.1

…lect tablets to balance (#51828) Signed-off-by: gengjun-git <[email protected]> (cherry picked from commit b550d07)

…lect tablets to balance (backport #51828) (#51851) Co-authored-by: gengjun-git <[email protected]>

…lect tablets to balance (backport #51828) (#51850) Co-authored-by: gengjun-git <[email protected]>

…lect tablets to balance (backport #51828) (#51849) Co-authored-by: gengjun-git <[email protected]>

…lect tablets to balance (StarRocks#51828) Signed-off-by: gengjun-git <[email protected]>

…lect tablets to balance (StarRocks#51828) Signed-off-by: gengjun-git <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>

gengjun-git requested a review from a team as a code owner October 12, 2024 03:07

github-actions bot added 3.3 3.2 3.1 labels Oct 12, 2024

mergify bot assigned gengjun-git Oct 12, 2024

fix

2b92088

Signed-off-by: gengjun-git <[email protected]>

gengjun-git force-pushed the fix_sort_index_null_bug_main branch from 683485d to 2b92088 Compare October 12, 2024 09:57

HangyuanLiu approved these changes Oct 12, 2024

View reviewed changes

gengjun-git enabled auto-merge (squash) October 12, 2024 11:27

andyziye disabled auto-merge October 12, 2024 11:52

andyziye merged commit b550d07 into StarRocks:main Oct 12, 2024
46 of 47 checks passed

github-actions bot removed the 3.3 label Oct 12, 2024

github-actions bot removed the 3.2 label Oct 12, 2024

github-actions bot removed the 3.1 label Oct 12, 2024

mergify bot pushed a commit that referenced this pull request Oct 12, 2024

[BugFix] Fix NullPointerException in getTabletsInHighLoadPath when se…

705a443

…lect tablets to balance (#51828) Signed-off-by: gengjun-git <[email protected]> (cherry picked from commit b550d07)

mergify bot pushed a commit that referenced this pull request Oct 12, 2024

[BugFix] Fix NullPointerException in getTabletsInHighLoadPath when se…

26be84f

…lect tablets to balance (#51828) Signed-off-by: gengjun-git <[email protected]> (cherry picked from commit b550d07)

This was referenced Oct 12, 2024

[BugFix] Fix NullPointerException in getTabletsInHighLoadPath when select tablets to balance (backport #51828) #51849

Merged

[BugFix] Fix NullPointerException in getTabletsInHighLoadPath when select tablets to balance (backport #51828) #51850

Merged

mergify bot pushed a commit that referenced this pull request Oct 12, 2024

[BugFix] Fix NullPointerException in getTabletsInHighLoadPath when se…

1faf285

…lect tablets to balance (#51828) Signed-off-by: gengjun-git <[email protected]> (cherry picked from commit b550d07)

mergify bot mentioned this pull request Oct 12, 2024

[BugFix] Fix NullPointerException in getTabletsInHighLoadPath when select tablets to balance (backport #51828) #51851

Merged

42 tasks

wanpengfei-git pushed a commit that referenced this pull request Oct 12, 2024

[BugFix] Fix NullPointerException in getTabletsInHighLoadPath when se…

374e2dd

…lect tablets to balance (backport #51828) (#51851) Co-authored-by: gengjun-git <[email protected]>

github-actions bot added the 3.1-merged label Oct 12, 2024

wanpengfei-git pushed a commit that referenced this pull request Oct 12, 2024

[BugFix] Fix NullPointerException in getTabletsInHighLoadPath when se…

2ecb310

…lect tablets to balance (backport #51828) (#51850) Co-authored-by: gengjun-git <[email protected]>

github-actions bot added the 3.2-merged label Oct 12, 2024

wanpengfei-git pushed a commit that referenced this pull request Oct 12, 2024

[BugFix] Fix NullPointerException in getTabletsInHighLoadPath when se…

d4e3043

…lect tablets to balance (backport #51828) (#51849) Co-authored-by: gengjun-git <[email protected]>

github-actions bot added the 3.3-merged label Oct 12, 2024

ZiheLiu pushed a commit to ZiheLiu/starrocks that referenced this pull request Oct 31, 2024

[BugFix] Fix NullPointerException in getTabletsInHighLoadPath when se…

bac3f60

…lect tablets to balance (StarRocks#51828) Signed-off-by: gengjun-git <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BugFix] Fix NullPointerException in getTabletsInHighLoadPath when select tablets to balance #51828

[BugFix] Fix NullPointerException in getTabletsInHighLoadPath when select tablets to balance #51828

gengjun-git commented Oct 12, 2024

gengjun-git commented Oct 12, 2024

mergify bot commented Oct 12, 2024

sonarcloud bot commented Oct 12, 2024

github-actions bot commented Oct 12, 2024

github-actions bot commented Oct 12, 2024

github-actions bot commented Oct 12, 2024

github-actions bot commented Oct 12, 2024

github-actions bot commented Oct 12, 2024

github-actions bot commented Oct 12, 2024

mergify bot commented Oct 12, 2024 •

edited

Loading

mergify bot commented Oct 12, 2024 •

edited

Loading

mergify bot commented Oct 12, 2024 •

edited

Loading

[BugFix] Fix NullPointerException in getTabletsInHighLoadPath when select tablets to balance #51828

[BugFix] Fix NullPointerException in getTabletsInHighLoadPath when select tablets to balance #51828

Conversation

gengjun-git commented Oct 12, 2024

Why I'm doing:

What I'm doing:

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

gengjun-git commented Oct 12, 2024

mergify bot commented Oct 12, 2024

✅ Branch has been successfully rebased

sonarcloud bot commented Oct 12, 2024

Quality Gate passed

github-actions bot commented Oct 12, 2024

[Java-Extensions Incremental Coverage Report]

github-actions bot commented Oct 12, 2024

[FE Incremental Coverage Report]

file detail

github-actions bot commented Oct 12, 2024

[BE Incremental Coverage Report]

github-actions bot commented Oct 12, 2024

github-actions bot commented Oct 12, 2024

github-actions bot commented Oct 12, 2024

mergify bot commented Oct 12, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Oct 12, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Oct 12, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Oct 12, 2024 •

edited

Loading

mergify bot commented Oct 12, 2024 •

edited

Loading

mergify bot commented Oct 12, 2024 •

edited

Loading