Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Enhance thread pool configs of backup restore #52111

Merged
merged 1 commit into from
Oct 21, 2024
Merged

[Enhancement] Enhance thread pool configs of backup restore #52111

merged 1 commit into from
Oct 21, 2024
+99 −72

Conversation

xiangguangyxg
Copy link
Contributor

@xiangguangyxg xiangguangyxg commented Oct 18, 2024 •
edited
Loading

Why I'm doing:

Some thread pool configs of backup restore is too small and cannot be modified dynamiclly.

What I'm doing:

make_snapshot_worker_count supports dynamic modification.
release_snapshot_worker_count supports dynamic modification.
upload_worker_count default value is changed from 1 to number of cpu cores and support dynamic modification.
download_worker_count default value is changed from 1 to number of cpu cores and support dynamic modification.
use download_worker_count as the max thread number of move_dir_thread_pool.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@xiangguangyxg xiangguangyxg requested review from a team as code owners October 18, 2024 10:13
@github-actions github-actions bot added behavior_changed documentation Improvements or additions to documentation 3.3 3.2 3.1 labels Oct 18, 2024
@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

❌ fail : 15 / 42 (35.71%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/agent/agent_server.cpp 11 32 34.38% [80, 83, 615, 616, 617, 618, 619, 620, 621, 622, 625, 626, 629, 630, 631, 632, 633, 634, 635, 637, 638]
🔵 be/src/http/action/update_config_action.cpp 4 10 40.00% [182, 186, 190, 193, 194, 195]

@andyziye andyziye merged commit 524afa2 into StarRocks:main Oct 21, 2024
75 of 77 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.3 label Oct 21, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 21, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 21, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 21, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 21, 2024
@xiangguangyxg @mergify
[Enhancement] Enhance thread pool configs of backup restore (#52111)
b2dac9e 
Signed-off-by: xiangguangyxg <[email protected]>
(cherry picked from commit 524afa2)
mergify bot pushed a commit that referenced this pull request Oct 21, 2024
@xiangguangyxg @mergify
[Enhancement] Enhance thread pool configs of backup restore (#52111)
99fd740 
Signed-off-by: xiangguangyxg <[email protected]>
(cherry picked from commit 524afa2)
This was referenced Oct 21, 2024
Merged
Merged
mergify bot pushed a commit that referenced this pull request Oct 21, 2024
@xiangguangyxg @mergify
[Enhancement] Enhance thread pool configs of backup restore (#52111)
5631778 
Signed-off-by: xiangguangyxg <[email protected]>
(cherry picked from commit 524afa2)

# Conflicts:
#	be/src/agent/agent_server.cpp
#	docs/en/administration/management/BE_configuration.md
#	docs/zh/administration/management/BE_configuration.md
@mergify mergify bot mentioned this pull request Oct 21, 2024
Merged
24 tasks
wanpengfei-git pushed a commit that referenced this pull request Oct 21, 2024
@mergify @xiangguangyxg
[Enhancement] Enhance thread pool configs of backup restore (backport #…
cfa1e06 
…52111) (#52139)

Co-authored-by: xiangguangyxg <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Oct 21, 2024
@mergify @xiangguangyxg
[Enhancement] Enhance thread pool configs of backup restore (backport #…
2844eb7 
…52111) (#52140)

Co-authored-by: xiangguangyxg <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Oct 21, 2024
@mergify @xiangguangyxg
[Enhancement] Enhance thread pool configs of backup restore (backport #…
372b2e0 
…52111) (#52141)

Signed-off-by: xiangguangyxg <[email protected]>
Co-authored-by: xiangguangyxg <[email protected]>
@xiangguangyxg xiangguangyxg deleted the backup_restore_config branch October 21, 2024 08:25
ZiheLiu pushed a commit to ZiheLiu/starrocks that referenced this pull request Oct 31, 2024
@xiangguangyxg @ZiheLiu
[Enhancement] Enhance thread pool configs of backup restore (StarRock…
37414ea 
…s#52111)

Signed-off-by: xiangguangyxg <[email protected]>
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
@xiangguangyxg @renzhimin7
[Enhancement] Enhance thread pool configs of backup restore (StarRock…
f6c1e1c 
…s#52111)

Signed-off-by: xiangguangyxg <[email protected]>
Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

@EsoragotoSpirit EsoragotoSpirit EsoragotoSpirit approved these changes

@kevincai kevincai kevincai approved these changes

Assignees

@xiangguangyxg xiangguangyxg

Labels
3.1-merged 3.2-merged 3.3-merged behavior_changed documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiangguangyxg @kevincai @EsoragotoSpirit @andyziye