Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] use cloud native persistent index by default #52209

Merged
merged 2 commits into from
Oct 23, 2024
Merged

[Enhancement] use cloud native persistent index by default #52209

merged 2 commits into from
Oct 23, 2024

Conversation

luohaha
Copy link
Contributor

@luohaha luohaha commented Oct 22, 2024

Why I'm doing:

What I'm doing:

When create PK table in shared-data mode, and user doesn't use specific persistent_index_type, then use CLOUD_NATIVE persistent index as default index type.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@luohaha luohaha requested a review from a team as a code owner October 22, 2024 11:51
wyb
wyb previously approved these changes Oct 22, 2024
View reviewed changes
fe/fe-core/src/main/java/com/starrocks/catalog/TableProperty.java Outdated Show resolved Hide resolved
@luohaha
update
7526688 
Signed-off-by: luohaha <[email protected]>
@luohaha luohaha force-pushed the enable-cloud-native-index-default branch from 6cb9c12 to 7526688 Compare October 23, 2024 04:37
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 23, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 9 / 11 (81.82%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/common/util/PropertyAnalyzer.java 3 4 75.00% [1348]
🔵 com/starrocks/catalog/TableProperty.java 5 6 83.33% [725]
🔵 com/starrocks/common/Config.java 1 1 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@luohaha luohaha merged commit 421b1e5 into StarRocks:main Oct 23, 2024
49 of 50 checks passed
luohaha added a commit to luohaha/starrocks that referenced this pull request Oct 28, 2024
@luohaha
[Enhancement] use cloud native persistent index by default (StarRocks…
23e567b 
…#52209)

Signed-off-by: luohaha <[email protected]>
@luohaha luohaha mentioned this pull request Oct 28, 2024
Merged
24 tasks
luohaha added a commit that referenced this pull request Oct 28, 2024
@luohaha
[Enhancement] use cloud native persistent index by default (backport #…
4de5325 
…52209) (#52387)

Signed-off-by: luohaha <[email protected]>
ZiheLiu pushed a commit to ZiheLiu/starrocks that referenced this pull request Oct 31, 2024
@luohaha @ZiheLiu
[Enhancement] use cloud native persistent index by default (StarRocks…
798059b 
…#52209)

Signed-off-by: luohaha <[email protected]>
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
@luohaha @renzhimin7
[Enhancement] use cloud native persistent index by default (StarRocks…
9a2c2fa 
…#52209)

Signed-off-by: luohaha <[email protected]>
Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HangyuanLiu HangyuanLiu HangyuanLiu approved these changes

@wyb wyb wyb approved these changes

Assignees

@luohaha luohaha

Labels
3.3-merged behavior_changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luohaha @wyb @HangyuanLiu