Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix alter table partition (*) set storage_cooldown_ttl error #52482

Merged
merged 1 commit into from
Oct 31, 2024
Merged

[BugFix] Fix alter table partition (*) set storage_cooldown_ttl error #52482

merged 1 commit into from
Oct 31, 2024
+72 −0

Conversation

meegoo
Copy link
Contributor

@meegoo meegoo commented Oct 30, 2024 •
edited
Loading

Why I'm doing:

What I'm doing:

Fixes https://github.com/StarRocks/StarRocksTest/issues/8775

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@meegoo meegoo requested a review from a team as a code owner October 30, 2024 22:14
@mergify mergify bot assigned meegoo Oct 30, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 2 / 2 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/alter/AlterJobExecutor.java 2 2 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@meegoo meegoo enabled auto-merge (squash) October 31, 2024 04:28
@meegoo meegoo merged commit d44ae38 into StarRocks:main Oct 31, 2024
46 of 47 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Oct 31, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Oct 31, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 31, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 31, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 31, 2024
@meegoo @mergify
[BugFix] Fix alter table partition (*) set storage_cooldown_ttl error (…
3340cfe 
…#52482)

Signed-off-by: meegoo <[email protected]>
(cherry picked from commit d44ae38)
@mergify mergify bot mentioned this pull request Oct 31, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Oct 31, 2024
@meegoo @mergify
[BugFix] Fix alter table partition (*) set storage_cooldown_ttl error (…
da0adcb 
…#52482)

Signed-off-by: meegoo <[email protected]>
(cherry picked from commit d44ae38)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/alter/AlterJobExecutor.java
#	test/sql/test_alter_table/R/test_alter_table_abnormal
#	test/sql/test_alter_table/T/test_alter_table_abnormal
@mergify mergify bot mentioned this pull request Oct 31, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Oct 31, 2024
@mergify @meegoo
[BugFix] Fix alter table partition (*) set storage_cooldown_ttl error…
421f133 
… (backport #52482) (#52493)

Co-authored-by: meegoo <[email protected]>
ZiheLiu pushed a commit to ZiheLiu/starrocks that referenced this pull request Oct 31, 2024
@meegoo @ZiheLiu
[BugFix] Fix alter table partition (*) set storage_cooldown_ttl error (…
cce448a 
…StarRocks#52482)

Signed-off-by: meegoo <[email protected]>
meegoo added a commit that referenced this pull request Nov 1, 2024
@mergify @meegoo
[BugFix] Fix alter table partition (*) set storage_cooldown_ttl error…
bc9c235 
… (backport #52482) (#52494)

Signed-off-by: meegoo <[email protected]>
Co-authored-by: meegoo <[email protected]>
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
@meegoo @renzhimin7
[BugFix] Fix alter table partition (*) set storage_cooldown_ttl error (…
5463c39 
…StarRocks#52482)

Signed-off-by: meegoo <[email protected]>
Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengjun-git gengjun-git gengjun-git approved these changes

@Astralidea Astralidea Astralidea approved these changes

Assignees

@meegoo meegoo

Labels
3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meegoo @Astralidea @gengjun-git