-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Enhance text base mv rewrite #52498
Merged
LiShuMing
merged 4 commits into
StarRocks:main
from
LiShuMing:fix/main/fix_mv_text_based_rewrite
Nov 1, 2024
Merged
[Enhancement] Enhance text base mv rewrite #52498
LiShuMing
merged 4 commits into
StarRocks:main
from
LiShuMing:fix/main/fix_mv_text_based_rewrite
Nov 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shuming.li <[email protected]>
Signed-off-by: shuming.li <[email protected]>
Signed-off-by: shuming.li <[email protected]>
Signed-off-by: shuming.li <[email protected]>
Quality Gate passedIssues Measures |
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 38 / 39 (97.44%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
satanson
approved these changes
Nov 1, 2024
Seaven
approved these changes
Nov 1, 2024
@Mergifyio backport branch-3.3 |
@Mergifyio backport branch-3.2 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 1, 2024
Signed-off-by: shuming.li <[email protected]> (cherry picked from commit 6029ee2)
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Nov 1, 2024
Signed-off-by: shuming.li <[email protected]> (cherry picked from commit 6029ee2) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/CachingMvPlanContextBuilder.java
42 tasks
LiShuMing
added a commit
that referenced
this pull request
Nov 4, 2024
Signed-off-by: shuming.li <[email protected]> (cherry picked from commit 6029ee2)
wanpengfei-git
pushed a commit
that referenced
this pull request
Nov 4, 2024
Co-authored-by: shuming.li <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Nov 4, 2024
Signed-off-by: shuming.li <[email protected]> Co-authored-by: shuming.li <[email protected]>
renzhimin7
pushed a commit
to renzhimin7/starrocks
that referenced
this pull request
Nov 7, 2024
Signed-off-by: shuming.li <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Query cannot be rewritten by mv-texted based rewrite if mv has
order by
and query hasorder by
even if the defined query are exactly the same because subquery will eliminatethe order by
in the subquery which cause text match failed:What I'm doing:
materialized_view_subuqery_text_match_max_count
parameter which means the real sub query match count limit.Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: