Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Enhance text base mv rewrite #52498

Merged

Conversation

LiShuMing
Copy link
Contributor

@LiShuMing LiShuMing commented Oct 31, 2024

Why I'm doing:

Query cannot be rewritten by mv-texted based rewrite if mv has order by and query has order by even if the defined query are exactly the same because subquery will eliminate the order by in the subquery which cause text match failed:

MV: select user_id, time, bitmap_union(to_bitmap(tag_id)) as a from user_tags group by user_id, time order by user_id, time;

Query: select user_id, count(time) from (MV) as t group by user_id limit 3

What I'm doing:

  • Register an extra ast key if the mv's defined query has order by elements and without limit, so can be used to rewrite for the eliminated sorted-by input query.
  • Correct the materialized_view_subuqery_text_match_max_count parameter which means the real sub query match count limit.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Signed-off-by: shuming.li <[email protected]>
Signed-off-by: shuming.li <[email protected]>
Signed-off-by: shuming.li <[email protected]>
Copy link

sonarcloud bot commented Oct 31, 2024

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 38 / 39 (97.44%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/CachingMvPlanContextBuilder.java 32 33 96.97% [312]
🔵 com/starrocks/sql/optimizer/rule/transformation/materialization/rule/TextMatchBasedRewriteRule.java 6 6 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@LiShuMing LiShuMing merged commit 6029ee2 into StarRocks:main Nov 1, 2024
50 checks passed
@LiShuMing LiShuMing deleted the fix/main/fix_mv_text_based_rewrite branch November 1, 2024 07:23
Copy link

github-actions bot commented Nov 1, 2024

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Nov 1, 2024
Copy link

github-actions bot commented Nov 1, 2024

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Nov 1, 2024
Copy link
Contributor

mergify bot commented Nov 1, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Nov 1, 2024

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 1, 2024
Signed-off-by: shuming.li <[email protected]>
(cherry picked from commit 6029ee2)
mergify bot pushed a commit that referenced this pull request Nov 1, 2024
Signed-off-by: shuming.li <[email protected]>
(cherry picked from commit 6029ee2)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/CachingMvPlanContextBuilder.java
LiShuMing added a commit that referenced this pull request Nov 4, 2024
Signed-off-by: shuming.li <[email protected]>
(cherry picked from commit 6029ee2)
wanpengfei-git pushed a commit that referenced this pull request Nov 4, 2024
wanpengfei-git pushed a commit that referenced this pull request Nov 4, 2024
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants