-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] avoid to extract constant expr as common expr in array_map #52541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: silverbullet233 <[email protected]>
silverbullet233
force-pushed
the
fix_array_map
branch
from
November 1, 2024 08:45
b6b3eb4
to
d296c2a
Compare
LiShuMing
approved these changes
Nov 1, 2024
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 1 / 1 (100.00%) file detail
|
Seaven
approved these changes
Nov 4, 2024
@Mergifyio backport branch-3.3 |
@Mergifyio backport branch-3.2 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 4, 2024
…map (#52541) Signed-off-by: silverbullet233 <[email protected]> (cherry picked from commit 442f969)
Merged
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Nov 4, 2024
…map (#52541) Signed-off-by: silverbullet233 <[email protected]> (cherry picked from commit 442f969)
Merged
42 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Nov 4, 2024
…map (backport #52541) (#52560) Co-authored-by: eyes_on_me <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Nov 4, 2024
…map (backport #52541) (#52559) Co-authored-by: eyes_on_me <[email protected]>
renzhimin7
pushed a commit
to renzhimin7/starrocks
that referenced
this pull request
Nov 7, 2024
…map (StarRocks#52541) Signed-off-by: silverbullet233 <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
In the
array_map
prepare phase, we will try to extract independent expressions from lambda expr as common expressions to avoid repeated calculations. At this time, the common expressions will be replaced withColumnRef
s.However, there was a place that was not considered before, If the expression itself is a constant, we should not replace it with a
ColumnRef
, otherwise we will lose some opportunities for const optimization of the function.Take the following query as an example,
@arr
was mistakenly replaced withColumnRef
, making it impossible forarray_contains
andarray_map
to apply optimization for const columns.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: