Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] avoid to extract constant expr as common expr in array_map #52541

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

silverbullet233
Copy link
Contributor

@silverbullet233 silverbullet233 commented Nov 1, 2024

Why I'm doing:

What I'm doing:

In the array_map prepare phase, we will try to extract independent expressions from lambda expr as common expressions to avoid repeated calculations. At this time, the common expressions will be replaced with ColumnRefs.

However, there was a place that was not considered before, If the expression itself is a constant, we should not replace it with a ColumnRef, otherwise we will lose some opportunities for const optimization of the function.

Take the following query as an example, @arr was mistakenly replaced with ColumnRef, making it impossible for array_contains and array_map to apply optimization for const columns.

set @arr=array_generate(1,10000);
select array_map(x->array_contains(@arr,x), array_generate(1,100000));
QueryTime
baseline 3.6s
after optimization 0.04s

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Copy link

github-actions bot commented Nov 1, 2024

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Nov 1, 2024

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Nov 1, 2024

[BE Incremental Coverage Report]

pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exprs/lambda_function.cpp 1 1 100.00% []

@silverbullet233 silverbullet233 merged commit 442f969 into StarRocks:main Nov 4, 2024
50 checks passed
@silverbullet233 silverbullet233 deleted the fix_array_map branch November 4, 2024 02:09
Copy link

github-actions bot commented Nov 4, 2024

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Nov 4, 2024
Copy link
Contributor

mergify bot commented Nov 4, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Nov 4, 2024

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 4, 2024
…map (#52541)

Signed-off-by: silverbullet233 <[email protected]>
(cherry picked from commit 442f969)
mergify bot pushed a commit that referenced this pull request Nov 4, 2024
…map (#52541)

Signed-off-by: silverbullet233 <[email protected]>
(cherry picked from commit 442f969)
wanpengfei-git pushed a commit that referenced this pull request Nov 4, 2024
wanpengfei-git pushed a commit that referenced this pull request Nov 4, 2024
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants