Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] support sys_log_warn_modules in fe conf #52709

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

dirtysalt
Copy link
Contributor

Why I'm doing:

There are a lot of hudi logs when pulling files. So I have to change hudi package log level to warn.

What I'm doing:

This PR is to do:

  1. extend fe.conf to support to change some modules to warn level.
  2. add some builtin modules to warn level.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Copy link

sonarcloud bot commented Nov 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

github-actions bot commented Nov 7, 2024

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Nov 7, 2024

[FE Incremental Coverage Report]

pass : 6 / 7 (85.71%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/common/Log4jConfig.java 5 6 83.33% [358]
🔵 com/starrocks/common/Config.java 1 1 100.00% []

Copy link

github-actions bot commented Nov 7, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@dirtysalt dirtysalt enabled auto-merge (squash) November 8, 2024 02:45
@dirtysalt dirtysalt merged commit a40c00f into StarRocks:main Nov 8, 2024
50 of 51 checks passed
Copy link

github-actions bot commented Nov 8, 2024

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

@Mergifyio backport branch-3.1

Copy link

github-actions bot commented Nov 8, 2024

@Mergifyio backport branch-3.0

Copy link
Contributor

mergify bot commented Nov 8, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Nov 8, 2024

backport branch-3.2

✅ Backports have been created

Copy link
Contributor

mergify bot commented Nov 8, 2024

backport branch-3.1

✅ Backports have been created

Copy link
Contributor

mergify bot commented Nov 8, 2024

backport branch-3.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 8, 2024
mergify bot pushed a commit that referenced this pull request Nov 8, 2024
Signed-off-by: yanz <[email protected]>
(cherry picked from commit a40c00f)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/common/Config.java
#	fe/fe-core/src/main/java/com/starrocks/common/Log4jConfig.java
mergify bot pushed a commit that referenced this pull request Nov 8, 2024
mergify bot pushed a commit that referenced this pull request Nov 8, 2024
Signed-off-by: yanz <[email protected]>
(cherry picked from commit a40c00f)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/common/Config.java
#	fe/fe-core/src/main/java/com/starrocks/common/Log4jConfig.java
@dirtysalt dirtysalt deleted the add-fe-warn-modules branch November 8, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants