Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Support Generated Column rewrite for logical view with customize column name #52981

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

srlch
Copy link
Contributor

@srlch srlch commented Nov 19, 2024

Why I'm doing:

In current implementation, if the logical view sepecify the customize column name which is different from the projection output of the SQL definition, optimizer will not rewrite Generated Column expression although all column have been output.
This issue is caused by lack of alias information in SelectItem in this case. The alias information can be found in scope for logical view.

What I'm doing:

  1. Use alias information in scope for logical view rewriting.
  2. Refactoring some code.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@srlch srlch requested a review from a team as a code owner November 19, 2024 02:15
@mergify mergify bot assigned srlch Nov 19, 2024
@srlch srlch changed the title [Enhancement] Support Generated Column rewrite for logical view with customize column name [BugFix] Support Generated Column rewrite for logical view with customize column name Nov 19, 2024
// use scope for view relation to analyze subqueryRelation, clear the pre-analyzed
// information first.
queryRelation.getGeneratedExprToColumnRef().clear();
visitSubquery((SubqueryRelation) queryRelation, scope);
node.setGeneratedExprToColumnRef(queryRelation.getGeneratedExprToColumnRef());
} else if (queryRelation instanceof SelectRelation) {
SelectRelation childSelectRelation = (SelectRelation) queryRelation;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most risky bug in this code is:
Potential ClassCastException due to unsafe casting.

You can modify the code like this:

// Check instance of expected class before casting
Map<String, String> viewRefAlias = new HashMap<>();
if (scope.getRelationId().getSourceNode() instanceof ViewRelation) {
    for (Field f : scope.getRelationFields().getAllFields()) {
        if (f.getOriginExpression() instanceof SlotRef) {
            viewRefAlias.put(((SlotRef) f.getOriginExpression()).getColumnName(), f.getName());
        }
    }
}

Map<SlotRef, String> slotRefToAlias = new HashMap<>();
for (SelectListItem item : childSelectRelation.getSelectList().getItems()) {
    if (item.isStar()) {
        slotRefToAlias.clear();
        break;
    }

    if (!(item.getExpr() instanceof SlotRef)) {
        continue;
    }

    SlotRef exprSlotRef = (SlotRef) item.getExpr();
    
    if (!viewRefAlias.isEmpty()) {
        String nameKey = exprSlotRef.getColumnName();
        if (viewRefAlias.containsKey(nameKey)) {
            slotRefToAlias.put(exprSlotRef, viewRefAlias.get(nameKey));
        }
    } else if (item.getAlias() != null && !item.getAlias().isEmpty()) {
        slotRefToAlias.put(exprSlotRef, item.getAlias());
    }
}

This change ensures the cast is safe by storing the result of the cast in a variable and checking before using it further.

…mize column name

Why I'm doing:
In current implementation, if the logical view sepcify the customize column name which is different
from the projection output of the SQL definition, optimizer will not rewrite Generated Column expression
although all column have been outputed.
This issue is caused by lack of alias information in SelectItem in this case. The alias information can be
found in scope for logical view.

What I'm doing:
1. Use alias information in scope for logical view rewriting.
2. Refactoring some code.

Signed-off-by: srlch <[email protected]>
Copy link

sonarcloud bot commented Nov 19, 2024

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

fail : 15 / 19 (78.95%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/analyzer/QueryAnalyzer.java 14 18 77.78% [195, 208, 284, 285]
🔵 com/starrocks/sql/analyzer/RelationId.java 1 1 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants