Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Refactor Starrocks LOG to reduce the log file size(part1) (backport #52099) #53145

Open
wants to merge 3 commits into
base: branch-3.3
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 22, 2024

Why I'm doing:

Refactor Starrocks LOG to reduce the log file size.

What I'm doing:

Change all BE level1 verbose log to level2 because some info log will be set to level 1 in the future pr.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #52099 done by [Mergify](https://mergify.com). ## Why I'm doing: Refactor Starrocks LOG to reduce the log file size.

What I'm doing:

Change all BE level1 verbose log to level2 because some info log will be set to level 1 in the future pr.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

…52099)

Signed-off-by: sevev <[email protected]>
(cherry picked from commit 0f04139)

# Conflicts:
#	be/src/exec/olap_utils.h
#	be/src/exec/pipeline/scan/olap_scan_context.cpp
#	be/src/exec/tablet_sink.cpp
#	be/src/storage/tablet.cpp
#	be/src/storage/tablet_updates.cpp
Copy link
Contributor Author

mergify bot commented Nov 22, 2024

Cherry-pick of 0f04139 has failed:

On branch mergify/bp/branch-3.3/pr-52099
Your branch is up to date with 'origin/branch-3.3'.

You are currently cherry-picking commit 0f041391bc.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   be/src/agent/agent_task.cpp
	modified:   be/src/agent/publish_version.cpp
	modified:   be/src/block_cache/disk_space_monitor.cpp
	modified:   be/src/connector/mysql_connector.cpp
	modified:   be/src/exec/connector_scan_node.cpp
	modified:   be/src/exec/es/es_scan_reader.cpp
	modified:   be/src/exec/mysql_scanner.cpp
	modified:   be/src/exec/pipeline/pipeline_driver_executor.cpp
	modified:   be/src/exec/pipeline/sort/partition_sort_sink_operator.cpp
	modified:   be/src/exec/schema_scan_node.cpp
	modified:   be/src/exec/schema_scanner.cpp
	modified:   be/src/exec/schema_scanner/schema_fe_metrics_scanner.cpp
	modified:   be/src/exec/tablet_info.cpp
	modified:   be/src/exprs/lambda_function.cpp
	modified:   be/src/gutil/atomicops-internals-x86.cc
	modified:   be/src/gutil/strings/split.cc
	modified:   be/src/runtime/lake_tablets_channel.cpp
	modified:   be/src/runtime/local_tablets_channel.cpp
	modified:   be/src/runtime/plan_fragment_executor.cpp
	modified:   be/src/runtime/routine_load/data_consumer_group.cpp
	modified:   be/src/runtime/routine_load/routine_load_task_executor.cpp
	modified:   be/src/storage/compaction.cpp
	modified:   be/src/storage/compaction_manager.cpp
	modified:   be/src/storage/compaction_task.h
	modified:   be/src/storage/default_compaction_policy.cpp
	modified:   be/src/storage/delta_writer.cpp
	modified:   be/src/storage/horizontal_compaction_task.cpp
	modified:   be/src/storage/inverted/clucene/clucene_inverted_reader.cpp
	modified:   be/src/storage/lake/delta_writer.cpp
	modified:   be/src/storage/lake/schema_change.cpp
	modified:   be/src/storage/lake/tablet_manager.cpp
	modified:   be/src/storage/lake/transactions.cpp
	modified:   be/src/storage/memtable.cpp
	modified:   be/src/storage/olap_runtime_range_pruner.hpp
	modified:   be/src/storage/persistent_index.cpp
	modified:   be/src/storage/publish_version_manager.cpp
	modified:   be/src/storage/replication_utils.cpp
	modified:   be/src/storage/rowset/json_column_compactor.cpp
	modified:   be/src/storage/rowset/json_column_iterator.cpp
	modified:   be/src/storage/rowset/json_column_writer.cpp
	modified:   be/src/storage/rowset/rowset.cpp
	modified:   be/src/storage/rowset/segment_iterator.cpp
	modified:   be/src/storage/schema_change.cpp
	modified:   be/src/storage/segment_flush_executor.cpp
	modified:   be/src/storage/segment_replicate_executor.cpp
	modified:   be/src/storage/size_tiered_compaction_policy.cpp
	modified:   be/src/storage/tablet_manager.cpp
	modified:   be/src/storage/task/engine_clone_task.cpp
	modified:   be/src/storage/txn_manager.cpp
	modified:   be/src/storage/update_manager.cpp
	modified:   be/src/storage/vertical_compaction_task.cpp
	modified:   be/src/util/dynamic_cache.h
	modified:   be/src/util/tdigest.cpp
	modified:   be/src/util/thrift_client.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   be/src/exec/olap_utils.h
	both modified:   be/src/exec/pipeline/scan/olap_scan_context.cpp
	both modified:   be/src/exec/tablet_sink.cpp
	both modified:   be/src/storage/tablet.cpp
	both modified:   be/src/storage/tablet_updates.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Nov 22, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) November 22, 2024 11:14
@mergify mergify bot closed this Nov 22, 2024
auto-merge was automatically disabled November 22, 2024 11:14

Pull request was closed

Copy link
Contributor Author

mergify bot commented Nov 22, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

Signed-off-by: sevev <[email protected]>
@sevev sevev reopened this Nov 22, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) November 22, 2024 11:21
sevev
sevev previously approved these changes Nov 22, 2024
Signed-off-by: sevev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant