Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] modify statistic cache expire-update logical #53344

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

Seaven
Copy link
Contributor

@Seaven Seaven commented Nov 28, 2024

Why I'm doing:

What I'm doing:

Before this PR:

  1. collect new statistics
  2. drop old statistics cache
  3. wait a moment and really update new statistics cache

This PR:

  1. collect new statistics
  2. update new statistics cache directly and replace old cache

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@Seaven Seaven requested a review from a team as a code owner November 28, 2024 12:57
@mergify mergify bot assigned Seaven Nov 28, 2024
if (columnStatistic.isPresent()) {
columnStatistics.add(StatisticsUtils.estimateColumnStatistics(table, column, columnStatistic.get()));
columnStatistics.add(
StatisticsUtils.estimateColumnStatistics(table, column, columnStatistic.get()));
} else {
columnStatistics.add(ConnectorTableColumnStats.unknown());
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most risky bug in this code is:
Potentially blocking operation in asynchronous execution.

You can modify the code like this:

try {
    ColumnBasicStatsCacheLoader loader = new ColumnBasicStatsCacheLoader();
    CompletableFuture<Map<ColumnStatsCacheKey, Optional<ColumnStatistic>>> future =
            loader.asyncLoadAll(cacheKeys, statsCacheRefresherExecutor);
    if (isSync) {
        // Use get() with a timeout to avoid indefinitely blocking if the operation hangs
        Map<ColumnStatsCacheKey, Optional<ColumnStatistic>> result = future.get(60, TimeUnit.SECONDS);
        columnStatistics.synchronous().putAll(result);
    } else {
        columnStatistics.synchronous().refresh();
        future.whenComplete((res, e) -> {
            if (e != null) {
                LOG.error("Error loading column statistics", e);
            } else {
                columnStatistics.synchronous().putAll(res);
            }
        });
    }
} catch (TimeoutException e) {
    LOG.error("Timeout occurred while refreshing column statistics", e);
} catch (Exception e) {
    LOG.warn("Failed to refresh getColumnStatistics", e);
}

This modification includes a timeout for the future.get() call to prevent indefinite blocking, and error handling within whenComplete to log any exceptions encountered during asynchronous execution.

@Seaven Seaven changed the title [Enhancement] update cache update logica [Enhancement] modify statistic cache update logical Nov 29, 2024
@Seaven Seaven changed the title [Enhancement] modify statistic cache update logical [Enhancement] modify statistic cache expire-update logical Nov 29, 2024
Signed-off-by: Seaven <[email protected]>
Signed-off-by: Seaven <[email protected]>
Copy link

sonarcloud bot commented Nov 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 51 / 57 (89.47%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/statistics/StatisticStorage.java 0 1 00.00% [97]
🔵 com/starrocks/sql/optimizer/statistics/CachedStatisticStorage.java 45 50 90.00% [308, 309, 310, 313, 314]
🔵 com/starrocks/statistic/AnalyzeMgr.java 6 6 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@kangkaisen kangkaisen merged commit a979bef into StarRocks:main Dec 2, 2024
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants