Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix ctas & insert into select with multi level partition table #53391

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

meegoo
Copy link
Contributor

@meegoo meegoo commented Dec 1, 2024

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@meegoo meegoo requested review from a team as code owners December 1, 2024 21:22
@mergify mergify bot assigned meegoo Dec 1, 2024
@github-actions github-actions bot added the 3.4 label Dec 1, 2024
Copy link

sonarcloud bot commented Dec 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
15.7% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link

github-actions bot commented Dec 2, 2024

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Dec 2, 2024

[FE Incremental Coverage Report]

pass : 77 / 81 (95.06%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/analyzer/CreateTableAnalyzer.java 51 55 92.73% [506, 514, 515, 516]
🔵 com/starrocks/sql/analyzer/SelectAnalyzer.java 3 3 100.00% []
🔵 com/starrocks/sql/ast/ColumnDef.java 4 4 100.00% []
🔵 com/starrocks/sql/ast/ListPartitionDesc.java 15 15 100.00% []
🔵 com/starrocks/sql/analyzer/FeNameFormat.java 4 4 100.00% []

Copy link

github-actions bot commented Dec 2, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@meegoo meegoo enabled auto-merge (squash) December 2, 2024 05:35
@meegoo meegoo merged commit 8b45db1 into StarRocks:main Dec 2, 2024
46 of 47 checks passed
Copy link

github-actions bot commented Dec 2, 2024

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Dec 2, 2024
Copy link
Contributor

mergify bot commented Dec 2, 2024

backport branch-3.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 2, 2024
wanpengfei-git pushed a commit that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants