Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lake][Delete 1/2] support delete from lake table #9352

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

wyb
Copy link
Contributor

@wyb wyb commented Jul 29, 2022

What type of PR is this:

  • bug
  • feature
  • enhancement
  • refactor
  • others

Which issues of this PR fixes :

Fixes #

Problem Summary(Required) :

  1. FE creates DeletePredicatePB which is used in BE tablet metadata directly.
  2. No longer use the old push task api.

@wyb
Copy link
Contributor Author

wyb commented Jul 29, 2022

run starrocks_fe_unittest

@wyb wyb changed the title [Lake][1/3] support delete from lake table [Lake][1/2] support delete from lake table Jul 29, 2022
Astralidea
Astralidea previously approved these changes Jul 29, 2022
@wyb wyb changed the title [Lake][1/2] support delete from lake table [Lake][Delete 1/2] support delete from lake table Jul 29, 2022
sduzh
sduzh previously approved these changes Aug 2, 2022
Astralidea
Astralidea previously approved these changes Aug 2, 2022
@wanpengfei-git wanpengfei-git added the Approved Ready to merge label Aug 2, 2022
@wanpengfei-git
Copy link
Collaborator

run starrocks_admit_test

1. FE creates DeletePredicatePB which is used in BE tablet metadata directly.
2. No longer use the old push task api.
@wyb wyb dismissed stale reviews from Astralidea and sduzh via 08df589 August 2, 2022 10:54
@wanpengfei-git
Copy link
Collaborator

run starrocks_admit_test

@wanpengfei-git
Copy link
Collaborator

[FE PR Coverage Check]

😞 fail : 276 / 398 (69.35%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/transaction/TransactionAlreadyCommitException.java 0 2 00.00% [8, 9]
🔵 com/starrocks/transaction/DatabaseTransactionMgr.java 0 4 00.00% [1318, 1319, 1320, 1321]
🔵 com/starrocks/leader/LeaderImpl.java 0 3 00.00% [452, 453, 460]
🔵 com/starrocks/rpc/LakeServiceClient.java 0 2 00.00% [65, 66]
🔵 com/starrocks/lake/Utils.java 2 3 66.67% [43]
🔵 com/starrocks/load/OlapDeleteJob.java 125 179 69.83% [161, 162, 164, 165, 166, 168, 180, 181, 182, 183, 185, 186, 187, 194, 195, 210, 211, 212, 235, 236, 237, 238, 239, 240, 241, 242, 243, 245, 247, 248, 250, 262, 269, 298, 302, 303, 304, 318, 319, 324, 325, 326, 327, 328, 329, 334, 340, 341, 342, 343, 345, 346, 361, 362]
🔵 com/starrocks/lake/delete/LakeDeleteJob.java 63 90 70.00% [72, 73, 75, 76, 77, 79, 96, 120, 121, 122, 123, 125, 126, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 156]
🔵 com/starrocks/load/DeleteHandler.java 52 73 71.23% [126, 158, 180, 186, 193, 201, 202, 203, 204, 205, 206, 208, 210, 218, 229, 372, 415, 598, 599, 600, 601]
🔵 com/starrocks/load/DeleteJob.java 34 42 80.95% [98, 99, 100, 124, 125, 126, 127, 175]

@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wyb
Copy link
Contributor Author

wyb commented Aug 2, 2022

run starrocks_admit_test

@wyb wyb merged commit e99eee9 into StarRocks:main Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants