-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lake][Delete 1/2] support delete from lake table #9352
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run starrocks_fe_unittest |
wyb
changed the title
[Lake][1/3] support delete from lake table
[Lake][1/2] support delete from lake table
Jul 29, 2022
Astralidea
previously approved these changes
Jul 29, 2022
wyb
changed the title
[Lake][1/2] support delete from lake table
[Lake][Delete 1/2] support delete from lake table
Jul 29, 2022
sduzh
reviewed
Aug 1, 2022
sduzh
reviewed
Aug 1, 2022
sduzh
previously approved these changes
Aug 2, 2022
Astralidea
previously approved these changes
Aug 2, 2022
run starrocks_admit_test |
1. FE creates DeletePredicatePB which is used in BE tablet metadata directly. 2. No longer use the old push task api.
run starrocks_admit_test |
[FE PR Coverage Check]😞 fail : 276 / 398 (69.35%) file detail
|
Kudos, SonarCloud Quality Gate passed! |
run starrocks_admit_test |
Astralidea
approved these changes
Aug 2, 2022
sduzh
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
Which issues of this PR fixes :
Fixes #
Problem Summary(Required) :