[BugFix] Fix hang because of empty scan ranges #9458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DorianZheng
reviewed
Aug 2, 2022
| return Status::OK(); | ||
| } | ||
|
|
||
| Status ConnectorScanNode::_start_scan_thread(RuntimeState* state) { | ||
| for (TScanRangeParams& scan_range : _scan_ranges) { | ||
| _create_and_init_scanner(state, scan_range.scan_range); | ||
| } | ||
| _num_scanners = _pending_scanners.size(); |
There was a problem hiding this comment.
when will _num_scanners == 0 happen?
There was a problem hiding this comment.
@DorianZheng when there is no scan file in this table.
There was a problem hiding this comment.
OK, got it. Why not prevent this case on FE?
There was a problem hiding this comment.
Yes. That would also solve the problem. It generates an EMPTY NODE.
There was a problem hiding this comment.
Why does it generate an empty node instead of return early?
DorianZheng
approved these changes
Aug 2, 2022
|
run starrocks_admit_test |
caneGuy
approved these changes
Aug 3, 2022
|
@Mergifyio backport branch-2.3 |
mergify bot
pushed a commit
that referenced
this pull request
Aug 17, 2022
(cherry picked from commit 9f538f4) # Conflicts: # be/src/exec/vectorized/connector_scan_node.cpp
✅ Backports have been created
|
|
@Mergifyio backport branch-2.4 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 17, 2022
(cherry picked from commit 9f538f4) # Conflicts: # be/test/formats/parquet/file_reader_test.cpp
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this：
Which issues of this PR fixes ：
Fixes #https://github.com/StarRocks/StarRocksTest/issues/870
Fixes #9411
Problem Summary(Required) ：
We don't handle empty scan range properly.